feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: remove duplicates from clangd quickfix assist

Browse Source 
Do not report quickfixes with a diagnostic since those are already
collected by the ClangdQuickFixFactory as builtin quickfixes.

Change-Id: I8d29a08b823291f8beaa762c09b7d29a4b9d0384
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
David Schulz
2022-05-13 14:57:08 +02:00
parent 85d2159e41
commit b2e2421d2d
3 changed files with 70 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/plugins/languageclient/languageclientquickfix.h
View File

@@ -35,7 +35,10 @@
#include <QPointer>
namespace TextEditor { class IAssistProposal; }
namespace TextEditor {
class IAssistProposal;
class GenericProposal;
} // namespace TextEditor
namespace LanguageClient {
@@ -52,6 +55,17 @@ private:
QPointer<Client> m_client;
};
class LANGUAGECLIENT_EXPORT CommandQuickFixOperation : public TextEditor::QuickFixOperation
{
public:
CommandQuickFixOperation(const LanguageServerProtocol::Command &command, Client *client);
void perform() override;
private:
LanguageServerProtocol::Command m_command;
QPointer<Client> m_client;
};
class LANGUAGECLIENT_EXPORT LanguageClientQuickFixProvider : public TextEditor::IAssistProvider
{
public:
@@ -77,10 +91,13 @@ public:
protected:
void setOnlyKinds(const QList<LanguageServerProtocol::CodeActionKind> &only);
Client *client() { return m_client; }
private:
void handleCodeActionResponse(const LanguageServerProtocol::CodeActionRequest::Response &response);
virtual void handleProposalReady(const TextEditor::QuickFixOperations &ops);
void handleCodeActionResponse(
const LanguageServerProtocol::CodeActionRequest::Response &response);
virtual TextEditor::GenericProposal *handleCodeActionResult(
const LanguageServerProtocol::CodeActionResult &result);
QSharedPointer<const TextEditor::AssistInterface> m_assistInterface;
Client *m_client = nullptr; // not owned