From b329b7220bce33f10e2a28fc8ceb6b4868232dcc Mon Sep 17 00:00:00 2001
From: Tobias Hunger <tobias.hunger@qt.io>
Date: Mon, 2 Mar 2020 10:26:56 +0100
Subject: [PATCH] ADS: Do not re-use variables

Change-Id: I2aee3d6684d40077acfe652638292901bd660ea6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
---
 src/libs/advanceddockingsystem/dockwidget.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/libs/advanceddockingsystem/dockwidget.cpp b/src/libs/advanceddockingsystem/dockwidget.cpp
index 72a59c5b1f4..760f425ae78 100644
--- a/src/libs/advanceddockingsystem/dockwidget.cpp
+++ b/src/libs/advanceddockingsystem/dockwidget.cpp
@@ -336,9 +336,9 @@ namespace ADS
 
     void DockWidget::toggleViewInternal(bool open)
     {
-        DockContainerWidget *dockContainerWidget = dockContainer();
-        DockWidget *topLevelDockWidgetBefore = dockContainerWidget
-                                                   ? dockContainerWidget->topLevelDockWidget()
+        const DockContainerWidget *const beforeDockContainerWidget = dockContainer();
+        DockWidget *topLevelDockWidgetBefore = beforeDockContainerWidget
+                                                   ? beforeDockContainerWidget->topLevelDockWidget()
                                                    : nullptr;
 
         if (open) {
@@ -359,7 +359,7 @@ namespace ADS
         // Here we need to call the dockContainer() function again, because if
         // this dock widget was unassigned before the call to showDockWidget() then
         // it has a dock container now
-        dockContainerWidget = dockContainer();
+        const DockContainerWidget *const dockContainerWidget = dockContainer();
         DockWidget *topLevelDockWidgetAfter = dockContainerWidget
                                                   ? dockContainerWidget->topLevelDockWidget()
                                                   : nullptr;