Sqlite: Add condition to index

Change-Id: I83851b2f9cd516f21bc7e8987c1b60efaa019bb1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>

src/libs/sqlite/sqliteindex.h

@@ -43,14 +43,16 @@ enum class IndexType
 class Index
 {
 public:
-    Index(Utils::SmallString &&tableName,
+    Index(Utils::SmallStringView tableName,
           Utils::SmallStringVector &&columnNames,
-          IndexType indexType=IndexType::Normal)
+          IndexType indexType = IndexType::Normal,
-        : m_tableName(std::move(tableName)),
+          Utils::SmallStringView condition = {})
-          m_columnNames(std::move(columnNames)),
+        : m_tableName(std::move(tableName))
-          m_indexType(indexType)
+        , m_columnNames(std::move(columnNames))
-    {
+        , m_indexType(indexType)
-    }
+        , m_condition{condition}
+
+    {}
 
     Utils::SmallString sqlStatement() const
     {
@@ -67,7 +69,9 @@ public:
                                          m_tableName,
                                          "(",
                                          m_columnNames.join(", "),
-                                         ")"});
+                                         ")",
+                                         m_condition.hasContent() ? " WHERE " : "",
+                                         m_condition});
     }
 
     void checkTableName() const
@@ -86,6 +90,7 @@ private:
     Utils::SmallString m_tableName;
     Utils::SmallStringVector m_columnNames;
     IndexType m_indexType;
+    Utils::SmallString m_condition;
 };
 
 using SqliteIndices = std::vector<Index>;

src/libs/sqlite/sqlitetable.h

@@ -134,20 +134,21 @@ public:
         m_tableConstraints.emplace_back(TablePrimaryKey{std::move(columnNames)});
     }
 
-    Index &addIndex(const SqliteColumnConstReferences &columns)
+    Index &addIndex(const SqliteColumnConstReferences &columns, Utils::SmallStringView condition = {})
     {
-        m_sqliteIndices.emplace_back(m_tableName.clone(), sqliteColumnNames(columns));
+        return m_sqliteIndices.emplace_back(m_tableName,
-
+                                            sqliteColumnNames(columns),
-        return m_sqliteIndices.back();
+                                            IndexType::Normal,
+                                            condition);
     }
 
-    Index &addUniqueIndex(const SqliteColumnConstReferences &columns)
+    Index &addUniqueIndex(const SqliteColumnConstReferences &columns,
+                          Utils::SmallStringView condition = {})
     {
-        m_sqliteIndices.emplace_back(m_tableName.clone(),
+        return m_sqliteIndices.emplace_back(m_tableName,
-                                     sqliteColumnNames(columns),
+                                            sqliteColumnNames(columns),
-                                     IndexType::Unique);
+                                            IndexType::Unique,
-
+                                            condition);
-        return m_sqliteIndices.back();
     }
 
     const SqliteColumns &columns() const

tests/unit/unittest/sqliteindex-test.cpp

@@ -73,4 +73,15 @@ TEST(Index, UniqueIndex)
 
     ASSERT_THAT(sqlStatement, Eq("CREATE UNIQUE INDEX IF NOT EXISTS index_tableName_column1 ON tableName(column1)"));
 }
+
+TEST(Index, Condition)
+{
+    Index index{"tableName", {"column1"}, IndexType::Normal, "column1 IS NOT NULL"};
+
+    auto sqlStatement = index.sqlStatement();
+
+    ASSERT_THAT(sqlStatement,
+                Eq("CREATE INDEX IF NOT EXISTS index_tableName_column1 ON tableName(column1) WHERE "
+                   "column1 IS NOT NULL"));
+}
 }

tests/unit/unittest/sqlitetable-test.cpp

@@ -107,11 +107,34 @@ TEST_F(SqliteTable, InitializeTableWithIndex)
     auto &column = table.addColumn("name");
     auto &column2 = table.addColumn("value");
     table.addIndex({column});
-    table.addIndex({column2});
+    table.addIndex({column2}, "value IS NOT NULL");
 
     EXPECT_CALL(databaseMock, execute(Eq("CREATE TABLE testTable(name, value)")));
     EXPECT_CALL(databaseMock, execute(Eq("CREATE INDEX IF NOT EXISTS index_testTable_name ON testTable(name)")));
-    EXPECT_CALL(databaseMock, execute(Eq("CREATE INDEX IF NOT EXISTS index_testTable_value ON testTable(value)")));
+    EXPECT_CALL(databaseMock,
+                execute(Eq("CREATE INDEX IF NOT EXISTS index_testTable_value ON testTable(value) "
+                           "WHERE value IS NOT NULL")));
+
+    table.initialize(databaseMock);
+}
+
+TEST_F(SqliteTable, InitializeTableWithUniqueIndex)
+{
+    InSequence sequence;
+    table.setName(tableName.clone());
+    auto &column = table.addColumn("name");
+    auto &column2 = table.addColumn("value");
+    table.addUniqueIndex({column});
+    table.addUniqueIndex({column2}, "value IS NOT NULL");
+
+    EXPECT_CALL(databaseMock, execute(Eq("CREATE TABLE testTable(name, value)")));
+    EXPECT_CALL(databaseMock,
+                execute(Eq(
+                    "CREATE UNIQUE INDEX IF NOT EXISTS index_testTable_name ON testTable(name)")));
+    EXPECT_CALL(databaseMock,
+                execute(Eq(
+                    "CREATE UNIQUE INDEX IF NOT EXISTS index_testTable_value ON testTable(value) "
+                    "WHERE value IS NOT NULL")));
 
     table.initialize(databaseMock);
 }