feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Take changes from header files into account immediately

Browse Source 
... in the dependent sources. That's also how the built-in code model
behaves, but clangd itself only does this when a document is saved.

Change-Id: I52d6badb0b7f063e5924c05dbf83a6e9849c9f6f
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2023-08-22 14:10:22 +02:00
parent 73c5cf29c4
commit b33b99e2d9
13 changed files with 82 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/plugins/clangcodemodel/test/clangdtests.cpp
View File

@@ -2061,6 +2061,47 @@ void ClangdTestExternalChanges::test()
QVERIFY(waitForSignalOrTimeout(newClient, &ClangdClient::textMarkCreated, timeOutInMs()));
}
ClangdTestIndirectChanges::ClangdTestIndirectChanges()
{
setProjectFileName("indirect-changes.pro");
setSourceFileNames({"main.cpp", "directheader.h", "indirectheader.h", "unrelatedheader.h"});
}
void ClangdTestIndirectChanges::test()
{
// Initially, everything is fine.
const TextDocument * const src = document("main.cpp");
QVERIFY(src);
QVERIFY(src->marks().isEmpty());
// Write into an indirectly included header file. Our source file should have diagnostics now.
const TextDocument * const indirectHeader = document("indirectheader.h");
QVERIFY(indirectHeader);
QTextCursor cursor(indirectHeader->document());
cursor.insertText("blubb");
while (src->marks().isEmpty())
QVERIFY(waitForSignalOrTimeout(client(), &ClangdClient::textMarkCreated, timeOutInMs()));
// Remove the inserted text again; the diagnostics should disappear.
cursor.document()->undo();
QVERIFY(cursor.document()->toPlainText().isEmpty());
while (!src->marks().isEmpty()) {
QVERIFY(waitForSignalOrTimeout(client(), &ClangdClient::highlightingResultsReady,
timeOutInMs()));
}
// Now write into a header file that is not included anywhere.
// We expect diagnostics only for the header itself.
const TextDocument * const unrelatedHeader = document("unrelatedheader.h");
QVERIFY(indirectHeader);
QTextCursor cursor2(unrelatedHeader->document());
cursor2.insertText("blubb");
while (waitForSignalOrTimeout(client(), &ClangdClient::textMarkCreated, timeOutInMs()))
;
QVERIFY(!unrelatedHeader->marks().isEmpty());
QVERIFY(src->marks().isEmpty());
}
} // namespace Tests
} // namespace Internal
} // namespace ClangCodeModel