feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Use qAsConst with non-const Qt containers in range-loops

Browse Source 
Change-Id: I7bd27f8317b62fe448e037d5a25e78b4c88c648d
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Alessandro Portale
2021-02-16 23:09:02 +01:00
parent dfa24f09ad
commit b3686d410d
6 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/debugger/qml/qmlengine.cpp
View File

@@ -1848,7 +1848,7 @@ void QmlEnginePrivate::messageReceived(const QByteArray &data)
int newColumn = sourceLineText.indexOf('(') + 1;
for (const Breakpoint &bp : v8Breakpoints) {
for (const Breakpoint &bp : qAsConst(v8Breakpoints)) {
QTC_ASSERT(bp, continue);
const BreakpointParameters &params = bp->requestedParameters();
@@ -1874,7 +1874,7 @@ void QmlEnginePrivate::messageReceived(const QByteArray &data)
if (inferiorStop) {
//Update breakpoint data
for (const Breakpoint &bp : v8Breakpoints) {
for (const Breakpoint &bp : qAsConst(v8Breakpoints)) {
QTC_ASSERT(bp, continue);
if (bp->functionName().isEmpty()) {
bp->setFunctionName(invocationText);
@@ -1887,7 +1887,7 @@ void QmlEnginePrivate::messageReceived(const QByteArray &data)
}
if (engine->state() == InferiorRunOk) {
for (const Breakpoint &bp : v8Breakpoints) {
for (const Breakpoint &bp : qAsConst(v8Breakpoints)) {
QTC_ASSERT(bp, continue);
if (breakpointsTemp.contains(bp->responseId()))
clearBreakpoint(bp);

4
src/plugins/debugger/qml/qmlinspectoragent.cpp
View File

@@ -268,7 +268,7 @@ void QmlInspectorAgent::onResult(quint32 queryId, const QVariant &value,
m_rootContexts.insert(engineId, qvariant_cast<ContextReference>(value));
if (m_rootContexts.size() == m_engines.size()) {
clearObjectTree();
for (const auto &engine : m_engines) {
for (const auto &engine : qAsConst(m_engines)) {
QString name = engine.name();
if (name.isEmpty())
name = QString::fromLatin1("Engine %1").arg(engine.debugId());
@@ -445,7 +445,7 @@ void QmlInspectorAgent::verifyAndInsertObjectInTree(const ObjectReference &objec
// Still not found? Maybe we're loading the engine itself.
if (engineId == -1) {
for (const auto &engine : m_engines) {
for (const auto &engine : qAsConst(m_engines)) {
if (engine.debugId() == objectDebugId) {
engineId = engine.debugId();
break;