forked from qt-creator/qt-creator
AbstractProcessStep: De-virtualize finish() method
Provide a setDoneHook() setter instead. The hook is introduced temporarily, as when all the subclasses are transformed to use the task tree, the done hook is going to be a part of the subclass' recipe. Task-number: QTCREATORBUG-29168 Change-Id: Idbc0f8b8a32c8df2fa5ecb73ed1cbaedad99620d Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
@@ -253,6 +253,11 @@ CMakeBuildStep::CMakeBuildStep(BuildStepList *bsl, Id id) :
|
||||
|
||||
connect(target(), &Target::activeRunConfigurationChanged,
|
||||
this, &CMakeBuildStep::updateBuildTargetsModel);
|
||||
|
||||
setDoneHook([this](bool) {
|
||||
updateDeploymentData();
|
||||
emit progress(100, {});
|
||||
});
|
||||
}
|
||||
|
||||
QVariantMap CMakeBuildStep::toMap() const
|
||||
@@ -795,14 +800,6 @@ void CMakeBuildStep::updateDeploymentData()
|
||||
buildSystem()->setDeploymentData(deploymentData);
|
||||
}
|
||||
|
||||
void CMakeBuildStep::finish(ProcessResult result)
|
||||
{
|
||||
updateDeploymentData();
|
||||
|
||||
emit progress(100, {});
|
||||
AbstractProcessStep::finish(result);
|
||||
}
|
||||
|
||||
// CMakeBuildStepFactory
|
||||
|
||||
CMakeBuildStepFactory::CMakeBuildStepFactory()
|
||||
|
||||
Reference in New Issue
Block a user