feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Coco: Use FilePath::searchInPath instead of Environment::searchInPath

Browse Source 
Not obviously better in this case, but I'd like to centralize
searching on the FilePath side.

Change-Id: I27cec97c0590cf27c3659b3aa262b86439670679
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-05-23 09:44:54 +02:00
parent b1957888dd
commit b3f7478373
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/coco/cocoplugin.cpp
View File

@@ -40,12 +40,13 @@ void CocoPluginPrivate::startCoco()
auto layout = new QFormLayout(); auto layout = new QFormLayout();
const Environment env = Environment::systemEnvironment(); const Environment env = Environment::systemEnvironment();
FilePath squishCocoPath = FilePath::fromString(env.value("SQUISHCOCO")); const FilePath squishCocoPath = FilePath::fromUserInput(env.value("SQUISHCOCO"));
const FilePaths candidates = env.findAllInPath("coveragebrowser", {squishCocoPath}); const FilePath candidate = FilePath("coveragebrowser").searchInPath({squishCocoPath},
FilePath::PrependToPath);
PathChooser cocoChooser; PathChooser cocoChooser;
if (!candidates.isEmpty()) if (!candidate.isEmpty())
cocoChooser.setFilePath(candidates.first()); cocoChooser.setFilePath(candidate);
cocoChooser.setExpectedKind(PathChooser::Command); cocoChooser.setExpectedKind(PathChooser::Command);
cocoChooser.setPromptDialogTitle(Tr::tr("Select a Squish Coco CoverageBrowser Executable")); cocoChooser.setPromptDialogTitle(Tr::tr("Select a Squish Coco CoverageBrowser Executable"));