QmlProfiler: managing failed starts gracefully

Change-Id: Ice0debcb6b83977b8f50dd154687e7c5c6abac7b
Reviewed-on: http://codereview.qt.nokia.com/2113
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
This commit is contained in:
Christiaan Janssen
2011-07-25 14:49:07 +02:00
parent 5f78511187
commit b421f3eca7
10 changed files with 21 additions and 16 deletions

View File

@@ -101,10 +101,10 @@ Valgrind::ValgrindRunner * CallgrindEngine::runner()
return &m_runner;
}
void CallgrindEngine::start()
bool CallgrindEngine::start()
{
emit outputReceived(tr("Profiling %1\n").arg(executable()), Utils::NormalMessageFormat);
ValgrindEngine::start();
return ValgrindEngine::start();
}
void CallgrindEngine::dump()

View File

@@ -49,7 +49,7 @@ public:
CallgrindEngine(Analyzer::IAnalyzerTool *tool, const Analyzer::AnalyzerStartParameters &sp,
ProjectExplorer::RunConfiguration *runConfiguration);
void start();
bool start();
Valgrind::Callgrind::ParseData *takeParserData();

View File

@@ -75,13 +75,13 @@ Valgrind::ValgrindRunner *MemcheckEngine::runner()
return &m_runner;
}
void MemcheckEngine::start()
bool MemcheckEngine::start()
{
m_runner.setParser(&m_parser);
emit outputReceived(tr("Analyzing memory of %1\n").arg(executable()),
Utils::NormalMessageFormat);
ValgrindEngine::start();
return ValgrindEngine::start();
}
void MemcheckEngine::stop()

View File

@@ -51,7 +51,7 @@ public:
MemcheckEngine(Analyzer::IAnalyzerTool *tool, const Analyzer::AnalyzerStartParameters &sp,
ProjectExplorer::RunConfiguration *runConfiguration);
void start();
bool start();
void stop();
QStringList suppressionFiles() const;

View File

@@ -77,7 +77,7 @@ ValgrindEngine::~ValgrindEngine()
delete m_progress;
}
void ValgrindEngine::start()
bool ValgrindEngine::start()
{
emit starting(this);
@@ -115,6 +115,8 @@ void ValgrindEngine::start()
runner()->startRemotely(sp.connParams);
else
runner()->start();
return true;
}
void ValgrindEngine::stop()

View File

@@ -63,7 +63,7 @@ public:
ProjectExplorer::RunConfiguration *runConfiguration);
~ValgrindEngine();
void start();
bool start();
void stop();
QString executable() const;