feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

KitManager: Scope KitGuard

Browse Source 
Scope KitGuard correctly to avoid emitting kitUpdated signal
when adding a kit.

Change-Id: Id9b0f92c7c2be8adaf7490cfbecfaceb8717b80f
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Aurindam Jana
2013-01-16 15:13:47 +01:00
committed by Tobias Hunger
parent f841f3743d
commit b437b988e5
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/projectexplorer/kitmanager.cpp
View File

@@ -446,12 +446,14 @@ void KitManager::addKit(Kit *k)
if (!k) if (!k)
return; return;
KitGuard g(k); {
foreach (KitInformation *ki, d->m_informationList) { KitGuard g(k);
if (!k->hasValue(ki->dataId())) foreach (KitInformation *ki, d->m_informationList) {
k->setValue(ki->dataId(), ki->defaultValue(k)); if (!k->hasValue(ki->dataId()))
else k->setValue(ki->dataId(), ki->defaultValue(k));
ki->fix(k); else
ki->fix(k);
}
} }
d->m_kitList.append(k); d->m_kitList.append(k);