From b46fc4a3b97bdd330c1259f12e7287772834cc37 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Mon, 21 Jan 2019 08:57:46 +0200 Subject: [PATCH] ProjectExplorer: Simplify Project::isKnownFile Use std::binary_search instead of lower_bound. The iterator is not needed. Change-Id: Ie40441c0780bcf0b912644c4cdfd2d73068fb441 Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/project.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/plugins/projectexplorer/project.cpp b/src/plugins/projectexplorer/project.cpp index 34680411b70..b593be2e7e2 100644 --- a/src/plugins/projectexplorer/project.cpp +++ b/src/plugins/projectexplorer/project.cpp @@ -733,10 +733,9 @@ bool Project::isKnownFile(const Utils::FileName &filename) const { if (d->m_sortedNodeList.empty()) return filename == projectFilePath(); - const auto end = std::end(d->m_sortedNodeList); const FileNode element(filename, FileType::Unknown, false); - const auto it = std::lower_bound(std::begin(d->m_sortedNodeList), end, &element, &nodeLessThan); - return (it == end) ? false : (*it)->filePath() == filename; + return std::binary_search(std::begin(d->m_sortedNodeList), std::end(d->m_sortedNodeList), + &element, nodeLessThan); } void Project::setProjectLanguages(Core::Context language)