feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: add tests for Position::fromFileName

Browse Source 
Change-Id: I321b91567e47e08883c7b991cd24d02bb8a9b9c6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
David Schulz
2023-05-12 10:59:04 +02:00
parent e2df60abc2
commit b4734ff727
4 changed files with 106 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/libs/utils/textutils.cpp
View File

@@ -32,7 +32,6 @@ Position Position::fromFileName(QStringView fileName, int &postfixPos)
Position pos;
if (match.hasMatch()) {
postfixPos = match.capturedStart(0);
pos.line = 0; // for the case that there's only a : at the end
if (match.lastCapturedIndex() > 0) {
pos.line = match.captured(1).toInt();
if (match.lastCapturedIndex() > 2) // index 2 includes the + or : for the column number
@@ -44,6 +43,8 @@ Position Position::fromFileName(QStringView fileName, int &postfixPos)
if (vsMatch.lastCapturedIndex() > 1) // index 1 includes closing )
pos.line = vsMatch.captured(2).toInt();
}
if (pos.line > 0 && pos.column < 0)
pos.column = 0; // if we got a valid line make sure to return a valid TextPosition
return pos;
}
@@ -264,4 +265,10 @@ void applyReplacements(QTextDocument *doc, const Replacements &replacements)
editCursor.endEditBlock();
}
QDebug &operator<<(QDebug &stream, const Position &pos)
{
stream << "line: " << pos.line << ", column: " << pos.column;
return stream;
}
} // namespace Utils::Text