From b489afd91b6dbfdb426bb95c661dccfdfe66fb4b Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Mon, 16 Aug 2021 12:36:01 +0200 Subject: [PATCH] AutoTest: Fix gathering failed Qt based tests Omit special and test data functions while collecting as these cannot be addressed at all. Change-Id: I3d79192cd07b4e7e2e76f04dfad36ef033593e71 Reviewed-by: David Schulz --- src/plugins/autotest/qtest/qttesttreeitem.cpp | 2 +- src/plugins/autotest/quick/quicktesttreeitem.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/autotest/qtest/qttesttreeitem.cpp b/src/plugins/autotest/qtest/qttesttreeitem.cpp index 6655bec5095..d9a7baaf5f4 100644 --- a/src/plugins/autotest/qtest/qttesttreeitem.cpp +++ b/src/plugins/autotest/qtest/qttesttreeitem.cpp @@ -226,7 +226,7 @@ static void collectFailedTestInfo(TestTreeItem *item, QListtype() == TestTreeItem::TestCase, return); QStringList testCases; item->forFirstLevelChildren([&testCases](ITestTreeItem *func) { - if (func->data(0, FailedRole).toBool()) { + if (func->type() == TestTreeItem::TestFunction && func->data(0, FailedRole).toBool()) { testCases << func->name(); } else { func->forFirstLevelChildren([&testCases, func](ITestTreeItem *dataTag) { diff --git a/src/plugins/autotest/quick/quicktesttreeitem.cpp b/src/plugins/autotest/quick/quicktesttreeitem.cpp index 1be0e7153b9..e923cef9c18 100644 --- a/src/plugins/autotest/quick/quicktesttreeitem.cpp +++ b/src/plugins/autotest/quick/quicktesttreeitem.cpp @@ -271,7 +271,7 @@ QList QuickTestTreeItem::getSelectedTestConfigurations() c QList QuickTestTreeItem::getFailedTestConfigurations() const { return testConfigurationsFor(this, [](TestTreeItem *it) { - return it->data(0, FailedRole).toBool(); + return it->data(0, FailedRole).toBool() && it->type() == TestTreeItem::TestFunction; }); }