From b507a0039f5979a172ca091bd942599ff961d80c Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 8 Jul 2024 20:17:20 +0200 Subject: [PATCH] QMakeStep: Simplify recipe Use conditional expression with nullItem. Change-Id: I38e14fceef1a7e3e72c6b3598831241966062bb5 Reviewed-by: Orgad Shaneh --- src/plugins/qmakeprojectmanager/qmakestep.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/plugins/qmakeprojectmanager/qmakestep.cpp b/src/plugins/qmakeprojectmanager/qmakestep.cpp index 65b79a7238a..fc8f446bf3e 100644 --- a/src/plugins/qmakeprojectmanager/qmakestep.cpp +++ b/src/plugins/qmakeprojectmanager/qmakestep.cpp @@ -298,13 +298,12 @@ Tasking::GroupItem QMakeStep::runRecipe() m_needToRunQMake = false; }; - QList processList = {onGroupSetup(onSetup), - onGroupDone(onDone, CallDoneIf::Success), - ProcessTask(onQMakeSetup, onProcessDone)}; - if (m_runMakeQmake) - processList << ProcessTask(onMakeQMakeSetup, onProcessDone); - - return Group(processList); + return Group { + onGroupSetup(onSetup), + ProcessTask(onQMakeSetup, onProcessDone), + m_runMakeQmake ? ProcessTask(onMakeQMakeSetup, onProcessDone) : nullItem, + onGroupDone(onDone, CallDoneIf::Success) + }; } void QMakeStep::setForced(bool b)