feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

MesonProjectManager: Hide KitAspectFactory implementations

Browse Source 
Change-Id: I7ba81771475905f63f4696b3d9073311eea0ee0a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
hjk
2023-08-17 18:12:06 +02:00
parent e08b2fda4d
commit b509006d1c
5 changed files with 117 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

109
src/plugins/mesonprojectmanager/ninjatoolkitaspect.cpp
View File

@@ -8,59 +8,11 @@
#include <utils/qtcassert.h>
using namespace ProjectExplorer;
namespace MesonProjectManager::Internal {
static const char TOOL_ID[] = "MesonProjectManager.MesonKitInformation.Ninja";
NinjaToolKitAspectFactory::NinjaToolKitAspectFactory()
{
setObjectName(QLatin1String("NinjaKitAspect"));
setId(TOOL_ID);
setDisplayName(Tr::tr("Ninja Tool"));
setDescription(Tr::tr("The Ninja tool to use when building a project with Meson.<br>"
"This setting is ignored when using other build systems."));
setPriority(9000);
}
ProjectExplorer::Tasks NinjaToolKitAspectFactory::validate(const ProjectExplorer::Kit *k) const
{
ProjectExplorer::Tasks tasks;
const auto tool = NinjaToolKitAspect::ninjaTool(k);
if (tool && !tool->isValid())
tasks << ProjectExplorer::BuildSystemTask{ProjectExplorer::Task::Warning,
Tr::tr("Cannot validate this Ninja executable.")};
return tasks;
}
void NinjaToolKitAspectFactory::setup(ProjectExplorer::Kit *k)
{
const auto tool = NinjaToolKitAspect::ninjaTool(k);
if (!tool) {
const auto autoDetected = MesonTools::ninjaWrapper();
if (autoDetected)
NinjaToolKitAspect::setNinjaTool(k, autoDetected->id());
}
}
void NinjaToolKitAspectFactory::fix(ProjectExplorer::Kit *k)
{
setup(k);
}
ProjectExplorer::KitAspectFactory::ItemList NinjaToolKitAspectFactory::toUserOutput(
const ProjectExplorer::Kit *k) const
{
const auto tool = NinjaToolKitAspect::ninjaTool(k);
if (tool)
return {{Tr::tr("Ninja"), tool->name()}};
return {{Tr::tr("Ninja"), Tr::tr("Unconfigured")}};
}
ProjectExplorer::KitAspect *NinjaToolKitAspectFactory::createKitAspect(ProjectExplorer::Kit *k) const
{
QTC_ASSERT(k, return nullptr);
return new ToolKitAspectWidget{k, this, ToolKitAspectWidget::ToolType::Ninja};
}
const char TOOL_ID[] = "MesonProjectManager.MesonKitInformation.Ninja";
void NinjaToolKitAspect::setNinjaTool(ProjectExplorer::Kit *kit, Utils::Id id)
{
@@ -74,4 +26,59 @@ Utils::Id NinjaToolKitAspect::ninjaToolId(const ProjectExplorer::Kit *kit)
return Utils::Id::fromSetting(kit->value(TOOL_ID));
}
// NinjaToolKitAspectFactory
class NinjaToolKitAspectFactory final : public ProjectExplorer::KitAspectFactory
{
public:
NinjaToolKitAspectFactory()
{
setObjectName(QLatin1String("NinjaKitAspect"));
setId(TOOL_ID);
setDisplayName(Tr::tr("Ninja Tool"));
setDescription(Tr::tr("The Ninja tool to use when building a project with Meson.<br>"
"This setting is ignored when using other build systems."));
setPriority(9000);
}
Tasks validate(const Kit *k) const final
{
Tasks tasks;
const auto tool = NinjaToolKitAspect::ninjaTool(k);
if (tool && !tool->isValid())
tasks << BuildSystemTask{Task::Warning,
Tr::tr("Cannot validate this Ninja executable.")};
return tasks;
}
void setup(Kit *k) final
{
const auto tool = NinjaToolKitAspect::ninjaTool(k);
if (!tool) {
const auto autoDetected = MesonTools::ninjaWrapper();
if (autoDetected)
NinjaToolKitAspect::setNinjaTool(k, autoDetected->id());
}
}
void fix(Kit *k) final
{
setup(k);
}
ItemList toUserOutput( const Kit *k) const
{
const auto tool = NinjaToolKitAspect::ninjaTool(k);
if (tool)
return {{Tr::tr("Ninja"), tool->name()}};
return {{Tr::tr("Ninja"), Tr::tr("Unconfigured")}};
}
KitAspect *createKitAspect(Kit *k) const final
{
return new ToolKitAspectWidget(k, this, ToolKitAspectWidget::ToolType::Ninja);
}
};
const NinjaToolKitAspectFactory theNinjaToolKitAspectFactory;
} // MesonProjectManager::Internal