From b53d1186eaba5693c222ba9ea231c8add595def6 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Tue, 25 Jul 2023 10:44:44 +0200
Subject: [PATCH] Valgrind: Remove one copied member when direct access is ok

Change-Id: I2813d062781571b50ae89e6f0482a4e72419ccde
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
---
 src/plugins/valgrind/suppressiondialog.cpp | 3 +--
 src/plugins/valgrind/suppressiondialog.h   | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/plugins/valgrind/suppressiondialog.cpp b/src/plugins/valgrind/suppressiondialog.cpp
index 6273580e82d..33be943ddd4 100644
--- a/src/plugins/valgrind/suppressiondialog.cpp
+++ b/src/plugins/valgrind/suppressiondialog.cpp
@@ -93,7 +93,6 @@ static bool equalSuppression(const Error &error, const Error &suppressed)
 
 SuppressionDialog::SuppressionDialog(MemcheckErrorView *view, const QList<Error> &errors)
   : m_view(view),
-    m_settings(view->settings()),
     m_cleanupIfCanceled(false),
     m_errors(errors),
     m_fileChooser(new PathChooser(this)),
@@ -191,7 +190,7 @@ void SuppressionDialog::accept()
         }
     }
 
-    m_settings->suppressions.addSuppressionFile(path);
+    m_view->settings()->suppressions.addSuppressionFile(path);
 
     const QModelIndexList indices = Utils::sorted(m_view->selectionModel()->selectedRows(),
                                                   [](const QModelIndex &l, const QModelIndex &r) {
diff --git a/src/plugins/valgrind/suppressiondialog.h b/src/plugins/valgrind/suppressiondialog.h
index b4aac0d644d..c042089ac6d 100644
--- a/src/plugins/valgrind/suppressiondialog.h
+++ b/src/plugins/valgrind/suppressiondialog.h
@@ -18,7 +18,6 @@ namespace Valgrind {
 namespace Internal {
 
 class MemcheckErrorView;
-class ValgrindBaseSettings;
 
 class SuppressionDialog : public QDialog
 {
@@ -33,7 +32,6 @@ private:
     void reject() override;
 
     MemcheckErrorView *m_view;
-    ValgrindBaseSettings *m_settings;
     bool m_cleanupIfCanceled;
     QList<XmlProtocol::Error> m_errors;