feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Fix crash on replaceSubtree

Browse Source 
Do not double-free oldNode.

Change-Id: Icce2d13b6afd24f2e37c5ca7e2b572a6784e69e1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Tobias Hunger
2018-05-03 10:30:34 +02:00
parent fd3a75d7f2
commit b57ce2d7a6
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/projectexplorer/projectnodes.cpp
View File

@@ -617,7 +617,6 @@ bool FolderNode::replaceSubtree(Node *oldNode, std::unique_ptr<Node> &&newNode)
} else { } else {
takeNode(oldNode); // Happens e.g. when project is shutting down takeNode(oldNode); // Happens e.g. when project is shutting down
} }
QTimer::singleShot(0, [oldNode]() { delete oldNode; });
} }
handleSubTreeChanged(this); handleSubTreeChanged(this);
return true; return true;