feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove BuildConfigWidget::init()

Browse Source 
It no longer serves a purpose.

Change-Id: Icdcb69c87112e295cefd4975dfa2b3d65818365a
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Daniel Teske
2012-11-08 17:35:59 +01:00
parent 8cbafa83b6
commit b5bbdb38d9
18 changed files with 54 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/genericprojectmanager/genericbuildconfiguration.cpp
View File

@@ -107,7 +107,7 @@ void GenericBuildConfiguration::setBuildDirectory(const QString &buildDirectory)
BuildConfigWidget *GenericBuildConfiguration::createConfigWidget()
{
return new GenericBuildSettingsWidget;
return new GenericBuildSettingsWidget(this);
}
/*!
@@ -229,7 +229,8 @@ BuildConfiguration::BuildType GenericBuildConfiguration::buildType() const
// GenericBuildSettingsWidget
////////////////////////////////////////////////////////////////////////////////////
GenericBuildSettingsWidget::GenericBuildSettingsWidget() : m_buildConfiguration(0)
GenericBuildSettingsWidget::GenericBuildSettingsWidget(GenericBuildConfiguration *bc)
: m_buildConfiguration(0)
{
QFormLayout *fl = new QFormLayout(this);
fl->setContentsMargins(0, -1, 0, -1);
@@ -240,6 +241,10 @@ GenericBuildSettingsWidget::GenericBuildSettingsWidget() : m_buildConfiguration(
m_pathChooser->setEnabled(true);
fl->addRow(tr("Build directory:"), m_pathChooser);
connect(m_pathChooser, SIGNAL(changed(QString)), this, SLOT(buildDirectoryChanged()));
m_buildConfiguration = bc;
m_pathChooser->setBaseDirectory(bc->target()->project()->projectDirectory());
m_pathChooser->setPath(m_buildConfiguration->rawBuildDirectory());
}
QString GenericBuildSettingsWidget::displayName() const
@@ -247,13 +252,6 @@ QString GenericBuildSettingsWidget::displayName() const
return tr("Generic Manager");
}
void GenericBuildSettingsWidget::init(BuildConfiguration *bc)
{
m_buildConfiguration = static_cast<GenericBuildConfiguration *>(bc);
m_pathChooser->setBaseDirectory(bc->target()->project()->projectDirectory());
m_pathChooser->setPath(m_buildConfiguration->rawBuildDirectory());
}
void GenericBuildSettingsWidget::buildDirectoryChanged()
{
m_buildConfiguration->setBuildDirectory(m_pathChooser->rawPath());