feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Polish AbstractProcessStep

Browse Source 
Make a bool const.

Change-Id: Icfddb851ce11e1d2149349e239dcca4b3fcbea0b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Tobias Hunger
2017-01-20 10:47:35 +01:00
committed by Tim Jenssen
parent 087d6d7472
commit b67c5736ef
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/projectexplorer/abstractprocessstep.cpp
View File

@@ -215,9 +215,8 @@ void AbstractProcessStep::run(QFutureInterface<bool> &fi)
void AbstractProcessStep::cleanUp(QProcess *process) void AbstractProcessStep::cleanUp(QProcess *process)
{ {
// The process has finished, leftover data is read in processFinished // The process has finished, leftover data is read in processFinished
bool returnValue = false;
processFinished(process->exitCode(), process->exitStatus()); processFinished(process->exitCode(), process->exitStatus());
returnValue = processSucceeded(process->exitCode(), process->exitStatus()) || m_ignoreReturnValue; const bool returnValue = processSucceeded(process->exitCode(), process->exitStatus()) || m_ignoreReturnValue;
m_outputParserChain.reset(); m_outputParserChain.reset();
m_process.reset(); m_process.reset();