feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LookupContext: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: Ia7ec4b427c5971d6bd375659b291a9aad2ead253
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-03 01:44:38 +01:00
parent a1cc8551cc
commit b6a6480084
13 changed files with 67 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/cplusplus/ResolveExpression.cpp
View File

@@ -730,7 +730,7 @@ bool ResolveExpression::visit(SimpleNameAST *ast)
QSet<const Declaration* >(_autoDeclarationsBeingResolved) << decl);
const ExpressionDocumentHelper exprHelper(exprTyper.preprocessedExpression(initializer),
_context.bindings()->control().data());
_context.bindings()->control().get());
const Document::Ptr exprDoc = exprHelper.document;
DeduceAutoCheck deduceAuto(ast->name->identifier(), exprDoc->translationUnit());
@@ -742,7 +742,7 @@ bool ResolveExpression::visit(SimpleNameAST *ast)
if (typeItems.empty())
continue;
Clone cloner(_context.bindings()->control().data());
Clone cloner(_context.bindings()->control().get());
for (int n = 0; n < typeItems.size(); ++ n) {
FullySpecifiedType newType = cloner.type(typeItems[n].type(), nullptr);