feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LookupContext: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: Ia7ec4b427c5971d6bd375659b291a9aad2ead253
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-03 01:44:38 +01:00
parent a1cc8551cc
commit b6a6480084
13 changed files with 67 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cppeditor/cppinsertvirtualmethods.cpp
View File

@@ -770,7 +770,7 @@ public:
if (!targetCoN)
targetCoN = targetContext.globalNamespace();
UseMinimalNames useMinimalNames(targetCoN);
Control *control = context().bindings()->control().data();
Control *control = context().bindings()->control().get();
QList<const Function *> insertedFunctions;
for (ClassItem *classItem : std::as_const(m_factory->classFunctionModel->classes)) {
if (classItem->checkState() == Qt::Unchecked)
@@ -904,7 +904,7 @@ public:
env.switchScope(decl->enclosingScope());
UseMinimalNames q(targetCoN);
env.enter(&q);
Control *control = context().bindings()->control().data();
Control *control = context().bindings()->control().get();
// rewrite the function type and name + create definition
const FullySpecifiedType type = rewriteType(decl->type(), &env, control);