feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LookupContext: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: Ia7ec4b427c5971d6bd375659b291a9aad2ead253
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-03 01:44:38 +01:00
parent a1cc8551cc
commit b6a6480084
13 changed files with 67 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/auto/cplusplus/cxx11/tst_cxx11.cpp
View File

@@ -229,7 +229,7 @@ void tst_cxx11::inlineNamespaceLookup()
snapshot.insert(doc);
LookupContext context(doc, snapshot);
QSharedPointer<Control> control = context.bindings()->control();
std::shared_ptr<Control> control = context.bindings()->control();
QList<LookupItem> results = context.lookup(control->identifier("foo"), doc->globalNamespace());
QCOMPARE(results.size(), 1); // the symbol is visible from the global scope