feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix crash when loading a .pyproject into Qt Creator with empty settings

Browse Source 
The build system is 0 as long as no kits are created.

Change-Id: Ia7f283071740dabe76ff3dd6b2f59e5ca214b7c2
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Friedemann Kleint
2023-11-29 12:13:43 +01:00
parent c0a3565362
commit b6c3de310e
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -501,7 +501,8 @@ QString RunConfigurationFactory::decoratedTargetName(const QString &targetName,
QList<RunConfigurationCreationInfo> QList<RunConfigurationCreationInfo>
RunConfigurationFactory::availableCreators(Target *target) const RunConfigurationFactory::availableCreators(Target *target) const
{ {
const QList<BuildTargetInfo> buildTargets = target->buildSystem()->applicationTargets(); auto *bs = target->buildSystem();
const auto buildTargets = bs ? bs->applicationTargets() : QList<BuildTargetInfo>{};
const bool hasAnyQtcRunnable = Utils::anyOf(buildTargets, const bool hasAnyQtcRunnable = Utils::anyOf(buildTargets,
Utils::equal(&BuildTargetInfo::isQtcRunnable, true)); Utils::equal(&BuildTargetInfo::isQtcRunnable, true));
return Utils::transform(buildTargets, [&](const BuildTargetInfo &ti) { return Utils::transform(buildTargets, [&](const BuildTargetInfo &ti) {

3
src/plugins/qmljstools/qmljsmodelmanager.cpp
View File

@@ -169,7 +169,8 @@ ModelManagerInterface::ProjectInfo ModelManager::defaultProjectInfoForProject(
// For an IDE things are a bit more complicated because source files might be edited, // For an IDE things are a bit more complicated because source files might be edited,
// and the directory of the executable might be outdated. // and the directory of the executable might be outdated.
// Here we try to get the directory of the executable, adding all targets // Here we try to get the directory of the executable, adding all targets
const auto appTargets = activeTarget->buildSystem()->applicationTargets(); auto *bs = activeTarget->buildSystem();
const auto appTargets = bs ? bs->applicationTargets() : QList<BuildTargetInfo>{};
for (const auto &target : appTargets) { for (const auto &target : appTargets) {
if (target.targetFilePath.isEmpty()) if (target.targetFilePath.isEmpty())
continue; continue;