From b758bb7e50b38a25729c4913527237331bd31d23 Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@qt.io>
Date: Mon, 26 Jul 2021 13:04:50 +0200
Subject: [PATCH] Sqlite: Make carray bind const

Carray is not changing the pointer so it is fine to use a const pointer.

Change-Id: Iad89666b6f543496e39cfeff17e069feb2002ff5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
---
 src/libs/sqlite/sqlitebasestatement.cpp | 12 ++++++------
 src/libs/sqlite/sqlitebasestatement.h   |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/libs/sqlite/sqlitebasestatement.cpp b/src/libs/sqlite/sqlitebasestatement.cpp
index 1600e6e9776..459913060f4 100644
--- a/src/libs/sqlite/sqlitebasestatement.cpp
+++ b/src/libs/sqlite/sqlitebasestatement.cpp
@@ -185,11 +185,11 @@ void BaseStatement::bind(int index, void *pointer)
         checkForBindingError(resultCode);
 }
 
-void BaseStatement::bind(int index, Utils::span<int> values)
+void BaseStatement::bind(int index, Utils::span<const int> values)
 {
     int resultCode = sqlite3_carray_bind(m_compiledStatement.get(),
                                          index,
-                                         values.data(),
+                                         const_cast<int *>(values.data()),
                                          static_cast<int>(values.size()),
                                          CARRAY_INT32,
                                          SQLITE_STATIC);
@@ -197,11 +197,11 @@ void BaseStatement::bind(int index, Utils::span<int> values)
         checkForBindingError(resultCode);
 }
 
-void BaseStatement::bind(int index, Utils::span<long long> values)
+void BaseStatement::bind(int index, Utils::span<const long long> values)
 {
     int resultCode = sqlite3_carray_bind(m_compiledStatement.get(),
                                          index,
-                                         values.data(),
+                                         const_cast<long long *>(values.data()),
                                          static_cast<int>(values.size()),
                                          CARRAY_INT64,
                                          SQLITE_STATIC);
@@ -209,11 +209,11 @@ void BaseStatement::bind(int index, Utils::span<long long> values)
         checkForBindingError(resultCode);
 }
 
-void BaseStatement::bind(int index, Utils::span<double> values)
+void BaseStatement::bind(int index, Utils::span<const double> values)
 {
     int resultCode = sqlite3_carray_bind(m_compiledStatement.get(),
                                          index,
-                                         values.data(),
+                                         const_cast<double *>(values.data()),
                                          static_cast<int>(values.size()),
                                          CARRAY_DOUBLE,
                                          SQLITE_STATIC);
diff --git a/src/libs/sqlite/sqlitebasestatement.h b/src/libs/sqlite/sqlitebasestatement.h
index c007f3d334c..8ba9de09e89 100644
--- a/src/libs/sqlite/sqlitebasestatement.h
+++ b/src/libs/sqlite/sqlitebasestatement.h
@@ -87,9 +87,9 @@ public:
     void bind(int index, long long value);
     void bind(int index, double value);
     void bind(int index, void *pointer);
-    void bind(int index, Utils::span<int> values);
-    void bind(int index, Utils::span<long long> values);
-    void bind(int index, Utils::span<double> values);
+    void bind(int index, Utils::span<const int> values);
+    void bind(int index, Utils::span<const long long> values);
+    void bind(int index, Utils::span<const double> values);
     void bind(int index, Utils::span<const char *> values);
     void bind(int index, Utils::SmallStringView value);
     void bind(int index, const Value &value);