feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

EditorFactory: Replace some virtual functions with data members

Browse Source 
Change-Id: I014cb57460c4e3a36bf7403960908b5ffec867ff
Reviewed-by: David Schulz <david.schulz@digia.com>
This commit is contained in:
hjk
2013-05-31 19:35:37 +02:00
parent be112d853a
commit b772001c82
38 changed files with 132 additions and 545 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
src/plugins/vcsbase/basevcssubmiteditorfactory.cpp
View File

@@ -32,58 +32,21 @@
namespace VcsBase {
namespace Internal {
class BaseVcsSubmitEditorFactoryPrivate
{
public:
BaseVcsSubmitEditorFactoryPrivate(const VcsBaseSubmitEditorParameters *parameters);
const VcsBaseSubmitEditorParameters *m_parameters;
const Core::Id m_id;
const QString m_displayName;
const QStringList m_mimeTypes;
};
BaseVcsSubmitEditorFactoryPrivate::BaseVcsSubmitEditorFactoryPrivate(const VcsBaseSubmitEditorParameters *parameters) :
m_parameters(parameters),
m_id(parameters->id),
m_displayName(QLatin1String(parameters->displayName)),
m_mimeTypes(QLatin1String(parameters->mimeType))
{
}
} // namespace Internal
BaseVcsSubmitEditorFactory::BaseVcsSubmitEditorFactory(const VcsBaseSubmitEditorParameters *parameters) :
d(new Internal::BaseVcsSubmitEditorFactoryPrivate(parameters))
BaseVcsSubmitEditorFactory::BaseVcsSubmitEditorFactory(const VcsBaseSubmitEditorParameters *parameters)
: m_parameters(parameters)
{
setId(parameters->id);
setDisplayName(QLatin1String(parameters->displayName));
addMimeType(parameters->mimeType);
}
BaseVcsSubmitEditorFactory::~BaseVcsSubmitEditorFactory()
{
delete d;
}
Core::IEditor *BaseVcsSubmitEditorFactory::createEditor(QWidget *parent)
{
return createBaseSubmitEditor(d->m_parameters, parent);
}
Core::Id BaseVcsSubmitEditorFactory::id() const
{
return d->m_id;
}
QString BaseVcsSubmitEditorFactory::displayName() const
{
return d->m_displayName;
}
QStringList BaseVcsSubmitEditorFactory::mimeTypes() const
{
return d->m_mimeTypes;
return createBaseSubmitEditor(m_parameters, parent);
}
} // namespace VcsBase