From b7862ae453cda0704432c9d3bc24afebae1e5680 Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 19 Jun 2020 15:52:29 +0200 Subject: [PATCH] LSP: Fix and simplify log size restriction logic Do not subtract from unsigned (size) values. Amends d15d15efa28eacf7bb85b91da72a612453be53de. Change-Id: I9a8b09d3733b49ea646ae8a14caefcf5c908fad3 Reviewed-by: Eike Ziller --- src/plugins/languageclient/lsplogger.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/languageclient/lsplogger.cpp b/src/plugins/languageclient/lsplogger.cpp index 843809357cb..923441d88e9 100644 --- a/src/plugins/languageclient/lsplogger.cpp +++ b/src/plugins/languageclient/lsplogger.cpp @@ -94,10 +94,10 @@ void LspLogger::log(const LspLogMessage::MessageSender sender, const BaseMessage &message) { std::list &clientLog = m_logs[clientName]; - for (auto delta = clientLog.size() - m_logSize + 1; delta > 0; --delta) + while (clientLog.size() >= m_logSize) clientLog.pop_front(); - m_logs[clientName].push_back({sender, QTime::currentTime(), message}); - emit newMessage(clientName, m_logs[clientName].back()); + clientLog.push_back({sender, QTime::currentTime(), message}); + emit newMessage(clientName, clientLog.back()); } std::list LspLogger::messages(const QString &clientName) const