feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Remove one LayoutBuilder::addRow() overload

Browse Source 
The flexibility here is getting in the way later when trying to
remove the dependency on aspects.

Change-Id: I7221e80f2067292c7c80aead8f6d739fb7878f7e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2023-04-24 17:06:32 +02:00
parent dad415b884
commit b7ca84c5ee
13 changed files with 34 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
View File

@@ -560,17 +560,17 @@ QWidget *CMakeBuildStep::createConfigWidget()
envWidget->setBaseEnvironmentText(baseEnvironmentText());
});
builder.addRow(clearBox);
builder.addRow(envWidget);
builder.addRow({clearBox});
builder.addRow({envWidget});
};
Layouting::Form builder;
builder.addRow(m_cmakeArguments);
builder.addRow(m_toolArguments);
builder.addRow({m_cmakeArguments});
builder.addRow({m_toolArguments});
builder.addRow({Tr::tr("Stage for installation:"), Layouting::Row{m_useStaging, m_stagingDir}});
if (m_useiOSAutomaticProvisioningUpdates)
builder.addRow(m_useiOSAutomaticProvisioningUpdates);
builder.addRow({m_useiOSAutomaticProvisioningUpdates});
builder.addRow({new QLabel(Tr::tr("Targets:")), frame});

2
src/plugins/cmakeprojectmanager/cmakeinstallstep.cpp
View File

@@ -107,7 +107,7 @@ QWidget *CMakeInstallStep::createConfigWidget()
setDisplayName(Tr::tr("Install", "ConfigWidget display name."));
Layouting::Form builder;
builder.addRow(m_cmakeArguments);
builder.addRow({m_cmakeArguments});
auto widget = builder.emerge(Layouting::WithoutMargins);