feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlPreview: Fix double deletion of RefreshTranslationWorker

Browse Source 
The RunControl takes ownership of its RunWorkers.

Change-Id: I720d4404f991651de5d5f7906fbea96f0e4e20ba
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
hjk
2023-11-20 18:27:28 +01:00
parent 6e219addb2
commit b86ca0947b
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmlpreview/qmlpreviewruncontrol.cpp
View File

@@ -84,11 +84,10 @@ private:
void stop() override; void stop() override;
QmlPreviewConnectionManager m_connectionManager; QmlPreviewConnectionManager m_connectionManager;
RefreshTranslationWorker m_refreshTranslationWorker;
}; };
QmlPreviewRunner::QmlPreviewRunner(RunControl *runControl, const QmlPreviewRunnerSetting &settings) QmlPreviewRunner::QmlPreviewRunner(RunControl *runControl, const QmlPreviewRunnerSetting &settings)
: RunWorker(runControl), m_refreshTranslationWorker(runControl, settings) : RunWorker(runControl)
{ {
setId("QmlPreviewRunner"); setId("QmlPreviewRunner");
m_connectionManager.setFileLoader(settings.fileLoader); m_connectionManager.setFileLoader(settings.fileLoader);
@@ -134,7 +133,7 @@ QmlPreviewRunner::QmlPreviewRunner(RunControl *runControl, const QmlPreviewRunne
runControl->initiateStop(); runControl->initiateStop();
}); });
addStartDependency(&m_refreshTranslationWorker); addStartDependency(new RefreshTranslationWorker(runControl, settings));
} }
void QmlPreviewRunner::start() void QmlPreviewRunner::start()