Vcs: Use a StringAspect again for settings().path()

This holds a path list, i.e. possibly several directories, separated
by ';' or ':'. PathChooser can't handle that. Long term this could
be something more sophisticate, but for now it's more a "string" than
one FilePath.

Change-Id: I6665c131e698db3afd268d6ab9bcf3d76a7c7289
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>

src/plugins/vcsbase/vcsbaseclientsettings.cpp

@@ -39,7 +39,7 @@ VcsBaseSettings::~VcsBaseSettings() = default;
 FilePaths VcsBaseSettings::searchPathList() const
 {
     // FIXME: Filepathify
-    return Utils::transform(path.value().split(HostOsInfo::pathListSeparator(), Qt::SkipEmptyParts),
+    return Utils::transform(path().split(HostOsInfo::pathListSeparator(), Qt::SkipEmptyParts),
                             &FilePath::fromUserInput);
 }