Help: Some cleanup

Change-Id: Ic6af45fda6c7fec57cf6c663a9d8f253e3851f15
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

src/plugins/help/filtersettingspage.cpp

@@ -24,14 +24,15 @@
 ****************************************************************************/
 
 #include "filtersettingspage.h"
+
 #include "helpconstants.h"
 #include "helptr.h"
-
-#include <QtCore/QVersionNumber>
-#include <QtHelp/QHelpFilterEngine>
-#include <QtHelp/QHelpFilterSettingsWidget>
 #include "localhelpmanager.h"
 
+#include <QHelpFilterEngine>
+#include <QHelpFilterSettingsWidget>
+#include <QVersionNumber>
+
 using namespace Help::Internal;
 
 FilterSettingsPage::FilterSettingsPage()

src/plugins/help/helpindexfilter.cpp

@@ -25,23 +25,20 @@
 
 #include "helpindexfilter.h"
 
-#include "helpicons.h"
 #include "helpmanager.h"
 #include "helptr.h"
-#include "topicchooser.h"
+#include "localhelpmanager.h"
 
 #include <coreplugin/icore.h>
 #include <coreplugin/helpmanager.h>
 #include <extensionsystem/pluginmanager.h>
 #include <utils/utilsicons.h>
 
+#include <QHelpEngine>
+#include <QHelpFilterEngine>
+#include <QHelpLink>
 #include <QIcon>
 
-#include "localhelpmanager.h"
-#include <QtHelp/QHelpEngine>
-#include <QtHelp/QHelpFilterEngine>
-#include <QtHelp/QHelpLink>
-
 using namespace Core;
 using namespace Help;
 using namespace Help::Internal;

src/plugins/help/helpindexfilter.h

@@ -52,7 +52,7 @@ public:
                 QString *newText, int *selectionStart, int *selectionLength) const override;
     void refresh(QFutureInterface<void> &future) override;
 
-    Q_INVOKABLE QStringList allIndices() const;
+    QStringList allIndices() const;
 
 signals:
     void linksActivated(const QMultiMap<QString, QUrl> &links, const QString &key) const;

src/plugins/help/localhelpmanager.h

@@ -32,8 +32,10 @@
 #include <QObject>
 #include <QUrl>
 
-QT_FORWARD_DECLARE_CLASS(QHelpFilterEngine)
+QT_BEGIN_NAMESPACE
-QT_FORWARD_DECLARE_CLASS(QHelpEngine)
+class QHelpFilterEngine;
+class QHelpEngine;
+QT_END_NAMESPACE
 
 class BookmarkManager;