diff --git a/src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.cpp b/src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.cpp index 113212be5fb..0b64294d0da 100644 --- a/src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.cpp +++ b/src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.cpp @@ -5,9 +5,11 @@ #include "makefileparserthread.h" -#include #include +#include +#include #include + #include #include @@ -20,7 +22,7 @@ namespace AutotoolsProjectManager::Internal { AutotoolsBuildSystem::AutotoolsBuildSystem(Target *target) : BuildSystem(target) - , m_cppCodeModelUpdater(new CppEditor::CppProjectUpdater) + , m_cppCodeModelUpdater(ProjectUpdaterFactory::createCppProjectUpdater()) { connect(target, &Target::activeBuildConfigurationChanged, this, [this] { requestParse(); }); connect(target->project(), &Project::projectFileIsDirty, this, [this] { requestParse(); }); diff --git a/src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.h b/src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.h index 8832323d6f9..45976a359a8 100644 --- a/src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.h +++ b/src/plugins/autotoolsprojectmanager/autotoolsbuildsystem.h @@ -7,7 +7,7 @@ #include -namespace CppEditor { class CppProjectUpdater; } +namespace ProjectExplorer { class ProjectUpdater; } namespace AutotoolsProjectManager::Internal { @@ -42,7 +42,7 @@ private: /// Responsible for parsing the makefiles asynchronously in a thread std::unique_ptr m_makefileParserThread; - CppEditor::CppProjectUpdater *m_cppCodeModelUpdater = nullptr; + ProjectExplorer::ProjectUpdater *m_cppCodeModelUpdater = nullptr; }; } // AutotoolsProjectManager::Internal diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp index b05fbbe9174..ff948fed01e 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp @@ -24,12 +24,12 @@ #include #include -#include #include #include #include #include +#include #include #include @@ -71,7 +71,7 @@ static Q_LOGGING_CATEGORY(cmakeBuildSystemLog, "qtc.cmake.buildsystem", QtWarnin CMakeBuildSystem::CMakeBuildSystem(CMakeBuildConfiguration *bc) : BuildSystem(bc) - , m_cppCodeModelUpdater(new CppEditor::CppProjectUpdater) + , m_cppCodeModelUpdater(ProjectUpdaterFactory::createCppProjectUpdater()) { // TreeScanner: connect(&m_treeScanner, &TreeScanner::finished, diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.h b/src/plugins/cmakeprojectmanager/cmakebuildsystem.h index bf0f2c581d2..6086146223b 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.h +++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.h @@ -10,14 +10,14 @@ #include #include -#include #include -namespace CppEditor { class CppProjectUpdater; } namespace ProjectExplorer { class ExtraCompiler; class FolderNode; + class ProjectUpdater; } + namespace Utils { class Process; class Link; @@ -225,7 +225,7 @@ private: ParseGuard m_currentGuard; - CppEditor::CppProjectUpdater *m_cppCodeModelUpdater = nullptr; + ProjectExplorer::ProjectUpdater *m_cppCodeModelUpdater = nullptr; QList m_extraCompilers; QList m_buildTargets; QSet m_cmakeFiles; diff --git a/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp b/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp index 2ca95d6ecb7..99d0e89ae17 100644 --- a/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp +++ b/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp @@ -8,8 +8,9 @@ #include #include -#include + #include + #include #include #include @@ -21,8 +22,10 @@ #include #include #include +#include #include #include + #include #include @@ -43,7 +46,6 @@ namespace Internal { namespace { - bool isGccCompiler(const QString &compilerName) { return compilerName.contains("gcc") @@ -312,7 +314,7 @@ void createTree(std::unique_ptr &root, CompilationDatabaseBuildSystem::CompilationDatabaseBuildSystem(Target *target) : BuildSystem(target) - , m_cppCodeModelUpdater(std::make_unique()) + , m_cppCodeModelUpdater(ProjectUpdaterFactory::createCppProjectUpdater()) , m_deployFileWatcher(new FileSystemWatcher(this)) { connect(target->project(), &CompilationDatabaseProject::rootProjectDirectoryChanged, diff --git a/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.h b/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.h index 71e2ac1a304..3b55927a9b2 100644 --- a/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.h +++ b/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.h @@ -15,12 +15,15 @@ #include -namespace CppEditor { class CppProjectUpdater; } -namespace ProjectExplorer { class Kit; } +namespace ProjectExplorer { +class Kit; +class ProjectUpdater; +} // ProjectExplorer + namespace Utils { class FileSystemWatcher; } -namespace CompilationDatabaseProjectManager { -namespace Internal { +namespace CompilationDatabaseProjectManager::Internal { + class CompilationDbParser; class CompilationDatabaseProject : public ProjectExplorer::Project @@ -49,7 +52,7 @@ public: void buildTreeAndProjectParts(); QFutureWatcher m_parserWatcher; - std::unique_ptr m_cppCodeModelUpdater; + std::unique_ptr m_cppCodeModelUpdater; MimeBinaryCache m_mimeBinaryCache; QByteArray m_projectFileHash; CompilationDbParser *m_parser = nullptr; @@ -68,5 +71,4 @@ public: CompilationDatabaseBuildConfigurationFactory(); }; -} // namespace Internal -} // namespace CompilationDatabaseProjectManager +} // CompilationDatabaseProjectManager::Internal diff --git a/src/plugins/cppeditor/CMakeLists.txt b/src/plugins/cppeditor/CMakeLists.txt index 0c83b99b58f..49fe02c17e7 100644 --- a/src/plugins/cppeditor/CMakeLists.txt +++ b/src/plugins/cppeditor/CMakeLists.txt @@ -69,7 +69,6 @@ add_qtc_plugin(CppEditor cppprojectinfogenerator.cpp cppprojectinfogenerator.h cppprojectpartchooser.cpp cppprojectpartchooser.h cppprojectupdater.cpp cppprojectupdater.h - cppprojectupdaterinterface.h cppqtstyleindenter.cpp cppqtstyleindenter.h cppquickfix.cpp cppquickfix.h cppquickfixassistant.cpp cppquickfixassistant.h diff --git a/src/plugins/cppeditor/cppeditor.qbs b/src/plugins/cppeditor/cppeditor.qbs index 160fd70aee2..45a7901817a 100644 --- a/src/plugins/cppeditor/cppeditor.qbs +++ b/src/plugins/cppeditor/cppeditor.qbs @@ -150,7 +150,6 @@ QtcPlugin { "cppprojectinfogenerator.h", "cppprojectupdater.cpp", "cppprojectupdater.h", - "cppprojectupdaterinterface.h", "cppquickfix.cpp", "cppquickfix.h", "cppquickfixassistant.cpp", diff --git a/src/plugins/cppeditor/cppeditorplugin.cpp b/src/plugins/cppeditor/cppeditorplugin.cpp index 13d62e4cee2..30fa3bdad9d 100644 --- a/src/plugins/cppeditor/cppeditorplugin.cpp +++ b/src/plugins/cppeditor/cppeditorplugin.cpp @@ -68,8 +68,6 @@ #include #include -#include - #include #include #include @@ -165,7 +163,6 @@ class CppEditorPluginPrivate : public QObject public: ~CppEditorPluginPrivate() { - ExtensionSystem::PluginManager::removeObject(&m_cppProjectUpdaterFactory); delete m_clangdSettingsPage; } @@ -231,7 +228,6 @@ void CppEditorPlugin::initialize() d->m_codeModelSettings.fromSettings(ICore::settings()); CppModelManager::registerJsExtension(); - ExtensionSystem::PluginManager::addObject(&d->m_cppProjectUpdaterFactory); setupMenus(); registerVariables(); diff --git a/src/plugins/cppeditor/cppprojectupdater.cpp b/src/plugins/cppeditor/cppprojectupdater.cpp index c75ee0cb522..f64c75ea5c9 100644 --- a/src/plugins/cppeditor/cppprojectupdater.cpp +++ b/src/plugins/cppeditor/cppprojectupdater.cpp @@ -11,6 +11,7 @@ #include #include +#include #include #include @@ -24,11 +25,6 @@ namespace CppEditor { CppProjectUpdater::CppProjectUpdater() = default; CppProjectUpdater::~CppProjectUpdater() = default; -void CppProjectUpdater::update(const ProjectUpdateInfo &projectUpdateInfo) -{ - update(projectUpdateInfo, {}); -} - void CppProjectUpdater::update(const ProjectUpdateInfo &projectUpdateInfo, const QList &extraCompilers) { @@ -108,15 +104,13 @@ void CppProjectUpdater::cancel() } namespace Internal { + CppProjectUpdaterFactory::CppProjectUpdaterFactory() { - setObjectName("CppProjectUpdaterFactory"); + setLanguage(Constants::CXX_LANGUAGE_ID); + setCreator([] { return new CppProjectUpdater; }); } -CppProjectUpdaterInterface *CppProjectUpdaterFactory::create() -{ - return new CppProjectUpdater; -} } // namespace Internal } // namespace CppEditor diff --git a/src/plugins/cppeditor/cppprojectupdater.h b/src/plugins/cppeditor/cppprojectupdater.h index a8cebc5b1e0..2a8999b69ee 100644 --- a/src/plugins/cppeditor/cppprojectupdater.h +++ b/src/plugins/cppeditor/cppprojectupdater.h @@ -5,7 +5,8 @@ #include "cppeditor_global.h" -#include "cppprojectupdaterinterface.h" +#include +#include #include @@ -17,19 +18,17 @@ namespace CppEditor { namespace Internal { // registered in extensionsystem's object pool for plugins with weak dependency to CppEditor -class CppProjectUpdaterFactory : public QObject +class CppProjectUpdaterFactory final + : public ProjectExplorer::ProjectUpdaterFactory { - Q_OBJECT public: CppProjectUpdaterFactory(); - - // keep the namespace, for the type name in the invokeMethod call - Q_INVOKABLE CppEditor::CppProjectUpdaterInterface *create(); }; } // namespace Internal -class CPPEDITOR_EXPORT CppProjectUpdater final : public QObject, public CppProjectUpdaterInterface +class CPPEDITOR_EXPORT CppProjectUpdater final + : public QObject, public ProjectExplorer::ProjectUpdater { Q_OBJECT @@ -37,9 +36,8 @@ public: CppProjectUpdater(); ~CppProjectUpdater() override; - void update(const ProjectExplorer::ProjectUpdateInfo &projectUpdateInfo) override; void update(const ProjectExplorer::ProjectUpdateInfo &projectUpdateInfo, - const QList &extraCompilers); + const QList &extraCompilers) override; void cancel() override; private: diff --git a/src/plugins/cppeditor/cppprojectupdaterinterface.h b/src/plugins/cppeditor/cppprojectupdaterinterface.h deleted file mode 100644 index cb5b797fd2f..00000000000 --- a/src/plugins/cppeditor/cppprojectupdaterinterface.h +++ /dev/null @@ -1,20 +0,0 @@ -// Copyright (C) 2016 The Qt Company Ltd. -// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 - -#pragma once - -#include - -namespace CppEditor { - -// FIXME: Remove -class CppProjectUpdaterInterface -{ -public: - virtual ~CppProjectUpdaterInterface() = default; - - virtual void update(const ProjectExplorer::ProjectUpdateInfo &projectUpdateInfo) = 0; - virtual void cancel() = 0; -}; - -} // namespace CppEditor diff --git a/src/plugins/genericprojectmanager/genericproject.cpp b/src/plugins/genericprojectmanager/genericproject.cpp index 20afb9f99c1..fcd621b9cce 100644 --- a/src/plugins/genericprojectmanager/genericproject.cpp +++ b/src/plugins/genericprojectmanager/genericproject.cpp @@ -3,8 +3,6 @@ #include "genericproject.h" -#include "genericbuildconfiguration.h" -#include "genericmakestep.h" #include "genericprojectconstants.h" #include "genericprojectmanagertr.h" @@ -13,10 +11,6 @@ #include #include -#include - -#include - #include #include #include @@ -27,6 +21,8 @@ #include #include #include +#include + #include #include #include @@ -156,7 +152,7 @@ private: QStringList m_cxxflags; QStringList m_cflags; - CppEditor::CppProjectUpdaterInterface *m_cppCodeModelUpdater = nullptr; + ProjectUpdater *m_cppCodeModelUpdater = nullptr; FileSystemWatcher m_deployFileWatcher; }; @@ -186,16 +182,7 @@ GenericProject::GenericProject(const Utils::FilePath &fileName) GenericBuildSystem::GenericBuildSystem(Target *target) : BuildSystem(target) { - QObject *projectUpdaterFactory = ExtensionSystem::PluginManager::getObjectByName( - "CppProjectUpdaterFactory"); - if (projectUpdaterFactory) { - const bool successFullyCreatedProjectUpdater - = QMetaObject::invokeMethod(projectUpdaterFactory, - "create", - Q_RETURN_ARG(CppEditor::CppProjectUpdaterInterface *, - m_cppCodeModelUpdater)); - QTC_CHECK(successFullyCreatedProjectUpdater); - } + m_cppCodeModelUpdater = ProjectUpdaterFactory::createCppProjectUpdater(); connect(target->project(), &Project::projectFileIsDirty, this, [this](const FilePath &p) { if (p.endsWith(".files")) diff --git a/src/plugins/mesonprojectmanager/mesonbuildsystem.cpp b/src/plugins/mesonprojectmanager/mesonbuildsystem.cpp index 8aacff10c92..806c2a7fe9f 100644 --- a/src/plugins/mesonprojectmanager/mesonbuildsystem.cpp +++ b/src/plugins/mesonprojectmanager/mesonbuildsystem.cpp @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include #include @@ -177,6 +177,7 @@ void MachineFileManager::cleanupMachineFiles() MesonBuildSystem::MesonBuildSystem(MesonBuildConfiguration *bc) : BuildSystem(bc) , m_parser(MesonToolKitAspect::mesonToolId(bc->kit()), bc->environment(), project()) + , m_cppCodeModelUpdater(ProjectUpdaterFactory::createCppProjectUpdater()) { qCDebug(mesonBuildSystemLog) << "Init"; connect(bc->target(), &ProjectExplorer::Target::kitChanged, this, [this] { @@ -239,8 +240,8 @@ void MesonBuildSystem::parsingCompleted(bool success) if (success) { setRootProjectNode(m_parser.takeProjectNode()); if (kit() && buildConfiguration()) { - ProjectExplorer::KitInfo kitInfo{kit()}; - m_cppCodeModelUpdater.update( + KitInfo kitInfo{kit()}; + m_cppCodeModelUpdater->update( {project(), QtSupport::CppKitInfo(kit()), buildConfiguration()->environment(), diff --git a/src/plugins/mesonprojectmanager/mesonbuildsystem.h b/src/plugins/mesonprojectmanager/mesonbuildsystem.h index b07d5aba4ce..bae78142a74 100644 --- a/src/plugins/mesonprojectmanager/mesonbuildsystem.h +++ b/src/plugins/mesonprojectmanager/mesonbuildsystem.h @@ -6,13 +6,13 @@ #include "mesonprojectparser.h" #include "kitdata.h" -#include - #include #include #include +namespace ProjectExplorer { class ProjectUpdater; } + namespace MesonProjectManager::Internal { class MesonBuildConfiguration; @@ -62,7 +62,7 @@ private: ProjectExplorer::BuildSystem::ParseGuard m_parseGuard; MesonProjectParser m_parser; - CppEditor::CppProjectUpdater m_cppCodeModelUpdater; + std::unique_ptr m_cppCodeModelUpdater; QStringList m_pendingConfigArgs; Utils::FileSystemWatcher m_IntroWatcher; KitData m_kitData; diff --git a/src/plugins/projectexplorer/CMakeLists.txt b/src/plugins/projectexplorer/CMakeLists.txt index 26c7d39d70a..35f9f776322 100644 --- a/src/plugins/projectexplorer/CMakeLists.txt +++ b/src/plugins/projectexplorer/CMakeLists.txt @@ -144,6 +144,7 @@ add_qtc_plugin(ProjectExplorer projectsettingswidget.cpp projectsettingswidget.h projecttree.cpp projecttree.h projecttreewidget.cpp projecttreewidget.h + projectupdater.cpp projectupdater.h projectwelcomepage.cpp projectwelcomepage.h projectwindow.cpp projectwindow.h projectwizardpage.cpp projectwizardpage.h diff --git a/src/plugins/projectexplorer/projectexplorer.qbs b/src/plugins/projectexplorer/projectexplorer.qbs index 8f5e7e75f57..b4b97f9cd4a 100644 --- a/src/plugins/projectexplorer/projectexplorer.qbs +++ b/src/plugins/projectexplorer/projectexplorer.qbs @@ -119,6 +119,7 @@ QtcPlugin { "projecttree.cpp", "projecttree.h", "projecttreewidget.cpp", "projecttreewidget.h", + "projectupdater.cpp", "projectupdater.h", "projectwindow.cpp", "projectwindow.h", "projectwizardpage.cpp", "projectwizardpage.h", "rawprojectpart.cpp", "rawprojectpart.h", diff --git a/src/plugins/projectexplorer/projectupdater.cpp b/src/plugins/projectexplorer/projectupdater.cpp new file mode 100644 index 00000000000..15143019f44 --- /dev/null +++ b/src/plugins/projectexplorer/projectupdater.cpp @@ -0,0 +1,58 @@ +// Copyright (C) 2023 The Qt Company Ltd. +// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 + +#include "projectupdater.h" + +#include "projectexplorerconstants.h" + +#include +#include +#include + +#include + +using namespace Utils; + +namespace ProjectExplorer { + +static QList &projectUpdaterFactories() +{ + static QList theProjectUpdaterFactories; + return theProjectUpdaterFactories; +} + +ProjectUpdaterFactory::ProjectUpdaterFactory() +{ + projectUpdaterFactories().append(this); +} + +ProjectUpdaterFactory::~ProjectUpdaterFactory() +{ + projectUpdaterFactories().removeOne(this); +} + +void ProjectUpdaterFactory::setLanguage(Id language) +{ + m_language = language; +} + +void ProjectUpdaterFactory::setCreator(const std::function &creator) +{ + m_creator = creator; +} + +ProjectUpdater *ProjectUpdaterFactory::createProjectUpdater(Id language) +{ + const QList &factories = projectUpdaterFactories(); + ProjectUpdaterFactory *factory = + findOrDefault(factories, equal(&ProjectUpdaterFactory::m_language, language)); + QTC_ASSERT(factory, return nullptr); + return factory->m_creator(); +} + +ProjectUpdater *ProjectUpdaterFactory::createCppProjectUpdater() +{ + return createProjectUpdater(Constants::CXX_LANGUAGE_ID); +} + +} // ProjectExplorer diff --git a/src/plugins/projectexplorer/projectupdater.h b/src/plugins/projectexplorer/projectupdater.h new file mode 100644 index 00000000000..ac448ec2fd0 --- /dev/null +++ b/src/plugins/projectexplorer/projectupdater.h @@ -0,0 +1,45 @@ +// Copyright (C) 2023 The Qt Company Ltd. +// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 + +#pragma once + +#include "projectexplorer_export.h" + +#include + +#include + +namespace ProjectExplorer { + +class ProjectUpdateInfo; +class ExtraCompiler; + +class PROJECTEXPLORER_EXPORT ProjectUpdater +{ +public: + virtual ~ProjectUpdater() = default; + + virtual void update(const ProjectUpdateInfo &projectUpdateInfo, + const QList &extraCompilers = {}) = 0; + virtual void cancel() = 0; +}; + +class PROJECTEXPLORER_EXPORT ProjectUpdaterFactory +{ +public: + ProjectUpdaterFactory(); + ~ProjectUpdaterFactory(); + + static ProjectUpdater *createProjectUpdater(Utils::Id language); + static ProjectUpdater *createCppProjectUpdater(); // Convenience for C++. + +protected: + void setLanguage(Utils::Id language); + void setCreator(const std::function &creator); + +private: + std::function m_creator; + Utils::Id m_language; +}; + +} // namespace ProjectExplorer diff --git a/src/plugins/qbsprojectmanager/qbsproject.cpp b/src/plugins/qbsprojectmanager/qbsproject.cpp index 737f7fc17e9..043d88199eb 100644 --- a/src/plugins/qbsprojectmanager/qbsproject.cpp +++ b/src/plugins/qbsprojectmanager/qbsproject.cpp @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include @@ -38,6 +37,7 @@ #include #include #include +#include #include #include #include @@ -151,7 +151,8 @@ static bool supportsNodeAction(ProjectAction action, const Node *node) QbsBuildSystem::QbsBuildSystem(QbsBuildConfiguration *bc) : BuildSystem(bc->target()), m_session(new QbsSession(this)), - m_cppCodeModelUpdater(new CppEditor::CppProjectUpdater), + m_cppCodeModelUpdater( + ProjectUpdaterFactory::createProjectUpdater(ProjectExplorer::Constants::CXX_LANGUAGE_ID)), m_buildConfiguration(bc) { connect(m_session, &QbsSession::newGeneratedFilesForSources, this, diff --git a/src/plugins/qbsprojectmanager/qbsproject.h b/src/plugins/qbsprojectmanager/qbsproject.h index e3dcc6f3466..cefda5869f8 100644 --- a/src/plugins/qbsprojectmanager/qbsproject.h +++ b/src/plugins/qbsprojectmanager/qbsproject.h @@ -20,7 +20,7 @@ #include -namespace CppEditor { class CppProjectUpdater; } +namespace ProjectExplorer { class ProjectUpdater; } namespace QbsProjectManager { namespace Internal { @@ -136,7 +136,7 @@ private: Utils::Environment m_lastParseEnv; std::unique_ptr m_parseRequest; - CppEditor::CppProjectUpdater *m_cppCodeModelUpdater = nullptr; + ProjectExplorer::ProjectUpdater *m_cppCodeModelUpdater = nullptr; QHash m_sourcesForGeneratedFiles; QList m_extraCompilers; diff --git a/src/plugins/qmakeprojectmanager/qmakeproject.cpp b/src/plugins/qmakeprojectmanager/qmakeproject.cpp index 53639778950..a21ed6bd72a 100644 --- a/src/plugins/qmakeprojectmanager/qmakeproject.cpp +++ b/src/plugins/qmakeprojectmanager/qmakeproject.cpp @@ -17,7 +17,6 @@ #include #include -#include #include #include @@ -31,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -202,7 +202,7 @@ DeploymentKnowledge QmakeProject::deploymentKnowledge() const QmakeBuildSystem::QmakeBuildSystem(QmakeBuildConfiguration *bc) : BuildSystem(bc) , m_qmakeVfs(new QMakeVfs) - , m_cppCodeModelUpdater(new CppEditor::CppProjectUpdater) + , m_cppCodeModelUpdater(ProjectUpdaterFactory::createCppProjectUpdater()) { setParseDelay(0); diff --git a/src/plugins/qmakeprojectmanager/qmakeproject.h b/src/plugins/qmakeprojectmanager/qmakeproject.h index 10f2a563709..62cd3c01b2c 100644 --- a/src/plugins/qmakeprojectmanager/qmakeproject.h +++ b/src/plugins/qmakeprojectmanager/qmakeproject.h @@ -20,8 +20,11 @@ class QMakeGlobals; class QMakeVfs; QT_END_NAMESPACE -namespace CppEditor { class CppProjectUpdater; } -namespace ProjectExplorer { class DeploymentData; } +namespace ProjectExplorer { +class DeploymentData; +class ProjectUpdater; +} // ProjectExplorer + namespace QtSupport { class ProFileReader; } namespace QmakeProjectManager { @@ -193,7 +196,7 @@ private: bool m_cancelEvaluate = false; QList m_partialEvaluate; - CppEditor::CppProjectUpdater *m_cppCodeModelUpdater = nullptr; + ProjectExplorer::ProjectUpdater *m_cppCodeModelUpdater = nullptr; Internal::CentralizedFolderWatcher *m_centralizedFolderWatcher = nullptr;