forked from qt-creator/qt-creator
Utils: Make Layouting::Group { .. } less weird
It had a implicit vertical layout leading to unneded layout nesting
in quite a few cases. The price is an added Column { ... } in those
places where the implicit vertical layout was sufficient before.
Change-Id: I3ae1f03f9c1d691bd0c563b0447edd03ee02bbd2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
@@ -347,12 +347,14 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildSystem *bs) :
|
||||
Column {
|
||||
m_configurationStates,
|
||||
Group {
|
||||
cmakeConfiguration,
|
||||
Row {
|
||||
bc->aspect<InitialCMakeArgumentsAspect>(),
|
||||
bc->aspect<AdditionalCMakeOptionsAspect>()
|
||||
},
|
||||
m_reconfigureButton,
|
||||
Column {
|
||||
cmakeConfiguration,
|
||||
Row {
|
||||
bc->aspect<InitialCMakeArgumentsAspect>(),
|
||||
bc->aspect<AdditionalCMakeOptionsAspect>()
|
||||
},
|
||||
m_reconfigureButton,
|
||||
}
|
||||
}
|
||||
}.setSpacing(0)
|
||||
}.attachTo(details, false);
|
||||
|
||||
@@ -97,7 +97,7 @@ CMakeSpecificSettingsPage::CMakeSpecificSettingsPage(CMakeSpecificSettings *sett
|
||||
Column {
|
||||
Group {
|
||||
Title(::CMakeProjectManager::Internal::CMakeSpecificSettings::tr("Adding Files")),
|
||||
s.afterAddFileSetting
|
||||
Column { s.afterAddFileSetting }
|
||||
},
|
||||
s.packageManagerAutoSetup,
|
||||
s.askBeforeReConfigureInitialParams,
|
||||
|
||||
Reference in New Issue
Block a user