From b8a78d6ceac77ba6540306cda80cbc5fd56d9a3b Mon Sep 17 00:00:00 2001 From: Mahmoud Badri Date: Mon, 20 Mar 2023 14:53:49 +0200 Subject: [PATCH] QmlDesigner: Fix qml warning in the states view Happens when dragging an invalid item on a state. The item is null but the check check for undefined. Better approach is to always use the ! operator. Change-Id: I036e0f2d5231b0b0eb67a8400551c93fa0654ecb Reviewed-by: Miikka Heikkinen --- share/qtcreator/qmldesigner/newstateseditor/Main.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/share/qtcreator/qmldesigner/newstateseditor/Main.qml b/share/qtcreator/qmldesigner/newstateseditor/Main.qml index fb0a0567ad3..4cd85bb1ad3 100644 --- a/share/qtcreator/qmldesigner/newstateseditor/Main.qml +++ b/share/qtcreator/qmldesigner/newstateseditor/Main.qml @@ -683,7 +683,7 @@ Rectangle { onEntered: function (drag) { let dragSource = (drag.source as StateThumbnail) - if (dragSource === undefined) + if (!dragSource) return if (dragSource.extendString !== stateThumbnail.extendString @@ -698,7 +698,7 @@ Rectangle { onDropped: function (drop) { let dropSource = (drop.source as StateThumbnail) - if (dropSource === undefined) + if (!dropSource) return if (dropSource.extendString !== stateThumbnail.extendString