From b8c9d79b9fdca342ebdadeec6313880d5eaa04d9 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Fri, 26 Jan 2024 09:23:29 +0100 Subject: [PATCH] Remove focus rect from some input fields on macOS The focus rect on macOS needs some space around the widget itself, otherwise it looks wrong. We already removed the focus rect for various input fields like locator and search (cmd+f), also remove it from filter input fields for the various output panes. Change-Id: I048453c06264c51ec28b5a0c9368fad7c01dc5a7 Reviewed-by: Reviewed-by: Marcus Tillmanns --- src/plugins/coreplugin/outputpanemanager.cpp | 1 + src/plugins/projectexplorer/projectwindow.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/plugins/coreplugin/outputpanemanager.cpp b/src/plugins/coreplugin/outputpanemanager.cpp index add16240e2f..c1eac2ade86 100644 --- a/src/plugins/coreplugin/outputpanemanager.cpp +++ b/src/plugins/coreplugin/outputpanemanager.cpp @@ -201,6 +201,7 @@ void IOutputPane::setupFilterUi(const Key &historyKey) m_filterOutputLineEdit->setFiltering(true); m_filterOutputLineEdit->setEnabled(false); m_filterOutputLineEdit->setHistoryCompleter(historyKey); + m_filterOutputLineEdit->setAttribute(Qt::WA_MacShowFocusRect, false); connect(m_filterOutputLineEdit, &FancyLineEdit::textChanged, this, &IOutputPane::updateFilter); connect(m_filterOutputLineEdit, &FancyLineEdit::returnPressed, diff --git a/src/plugins/projectexplorer/projectwindow.cpp b/src/plugins/projectexplorer/projectwindow.cpp index b9e47c1332e..547faa91572 100644 --- a/src/plugins/projectexplorer/projectwindow.cpp +++ b/src/plugins/projectexplorer/projectwindow.cpp @@ -161,6 +161,7 @@ QWidget *BuildSystemOutputWindow::toolBar() m_filterOutputLineEdit->setButtonIcon(FancyLineEdit::Left, Utils::Icons::MAGNIFIER.icon()); m_filterOutputLineEdit->setFiltering(true); m_filterOutputLineEdit->setHistoryCompleter("ProjectsMode.BuildSystemOutput.Filter"); + m_filterOutputLineEdit->setAttribute(Qt::WA_MacShowFocusRect, false); connect(m_filterOutputLineEdit, &FancyLineEdit::textChanged, this,