feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Tracing: CtfVisualizer: Add menu to restrict view to certain threads

Browse Source 
Add a new dropdown menu to select which threads should be displayed.
If no threads are selected, all are shown (this is why the word
'restriction' was chosen). At the moment this only affects the
timeline view, see the follow up for the statistics view.

Change-Id: Ib3b08ea895e852189156e23feb8dea5f843cceb3
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Tim Henning
2019-10-17 13:36:37 +02:00
parent ee7aad5719
commit b90200cb19
6 changed files with 92 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/plugins/ctfvisualizer/ctfvisualizertool.cpp
View File

@@ -29,6 +29,7 @@
#include "ctfstatisticsmodel.h"
#include "ctfstatisticsview.h"
#include "ctftimelinemodel.h"
#include "ctfvisualizertraceview.h"
#include <coreplugin/actionmanager/actioncontainer.h>
@@ -36,6 +37,7 @@
#include <coreplugin/icore.h>
#include <coreplugin/progressmanager/progressmanager.h>
#include <debugger/analyzer/analyzerconstants.h>
#include <utils/utilsicons.h>
#include <QAction>
#include <QApplication>
@@ -62,6 +64,8 @@ CtfVisualizerTool::CtfVisualizerTool()
, m_statisticsModel(new CtfStatisticsModel(this))
, m_statisticsView(nullptr)
, m_traceManager(new CtfTraceManager(this, m_modelAggregator.get(), m_statisticsModel.get()))
, m_restrictToThreadsButton(new QToolButton)
, m_restrictToThreadsMenu(new QMenu(m_restrictToThreadsButton))
{
ActionContainer *menu = ActionManager::actionContainer(Debugger::Constants::M_DEBUG_ANALYZER);
ActionContainer *options = ActionManager::createMenu(Constants::CtfVisualizerMenuId);
@@ -78,6 +82,16 @@ CtfVisualizerTool::CtfVisualizerTool()
options->addAction(command);
m_perspective.setAboutToActivateCallback([this]() { createViews(); });
m_restrictToThreadsButton->setIcon(Utils::Icons::FILTER.icon());
m_restrictToThreadsButton->setToolTip(tr("Restrict to threads"));
m_restrictToThreadsButton->setPopupMode(QToolButton::InstantPopup);
m_restrictToThreadsButton->setProperty("noArrow", true);
m_restrictToThreadsButton->setMenu(m_restrictToThreadsMenu);
connect(m_restrictToThreadsMenu, &QMenu::triggered,
this, &CtfVisualizerTool::toggleThreadRestriction);
m_perspective.addToolBarWidget(m_restrictToThreadsButton);
}
CtfVisualizerTool::~CtfVisualizerTool() = default;
@@ -116,6 +130,24 @@ void CtfVisualizerTool::createViews()
m_perspective.setAboutToActivateCallback(Utils::Perspective::Callback());
}
void CtfVisualizerTool::setAvailableThreads(const QList<CtfTimelineModel *> &threads)
{
m_restrictToThreadsMenu->clear();
for (auto timelineModel : threads) {
QAction *action = m_restrictToThreadsMenu->addAction(timelineModel->displayName());
action->setCheckable(true);
action->setData(timelineModel->tid());
action->setChecked(m_traceManager->isRestrictedTo(timelineModel->tid()));
}
}
void CtfVisualizerTool::toggleThreadRestriction(QAction *action)
{
const int tid = action->data().toInt();
m_traceManager->setThreadRestriction(tid, action->isChecked());
}
Timeline::TimelineModelAggregator *CtfVisualizerTool::modelAggregator() const
{
return m_modelAggregator.get();
@@ -169,6 +201,7 @@ void CtfVisualizerTool::loadJson()
zoomControl()->setTrace(m_traceManager->traceBegin(), m_traceManager->traceEnd() + m_traceManager->traceDuration() / 20);
zoomControl()->setRange(m_traceManager->traceBegin(), m_traceManager->traceEnd() + m_traceManager->traceDuration() / 20);
}
setAvailableThreads(m_traceManager->getSortedThreads());
thread->deleteLater();
delete task;
delete futureInterface;