From b91632e642e738294acaf30a9e80a27b70d0471d Mon Sep 17 00:00:00 2001 From: Tim Jenssen Date: Thu, 8 Dec 2016 22:31:43 +0100 Subject: [PATCH] CMake: fix crash while clicking context menu It crashed if the root project had some error and I tried to build a subproject. Change-Id: I13dc620402a5f79e507e7da3fedb5eb09a4112da Reviewed-by: Alexander Drozdov Reviewed-by: Tobias Hunger --- src/plugins/cmakeprojectmanager/cmakeprojectplugin.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/plugins/cmakeprojectmanager/cmakeprojectplugin.cpp b/src/plugins/cmakeprojectmanager/cmakeprojectplugin.cpp index 6febf97b001..96224f009cf 100644 --- a/src/plugins/cmakeprojectmanager/cmakeprojectplugin.cpp +++ b/src/plugins/cmakeprojectmanager/cmakeprojectplugin.cpp @@ -112,15 +112,17 @@ void CMakeProjectPlugin::updateContextActions(ProjectExplorer::Node *node, ProjectExplorer::Project *project) { CMakeTargetNode *targetNode = dynamic_cast(node); + // as targetNode can be deleted while the menu is open, we keep only the + const QString targetDisplayName = targetNode ? targetNode->displayName() : QString(); CMakeProject *cmProject = dynamic_cast(project); // Build Target: disconnect(m_buildTargetContextAction); - m_buildTargetContextAction->setParameter(targetNode ? targetNode->displayName() : QString()); + m_buildTargetContextAction->setParameter(targetDisplayName); m_buildTargetContextAction->setEnabled(targetNode); m_buildTargetContextAction->setVisible(targetNode); if (cmProject && targetNode) { connect(m_buildTargetContextAction, &Utils::ParameterAction::triggered, - cmProject, [cmProject, targetNode]() { cmProject->buildCMakeTarget(targetNode->displayName()); }); + cmProject, [cmProject, targetDisplayName]() { cmProject->buildCMakeTarget(targetDisplayName); }); } }