feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Perforce: Move logging the error directly into the synchronousProcess()

Browse Source 
Change-Id: I9d090f2da36d3868e9b4ca2a7f297be62e36e65a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2024-01-21 22:01:14 +01:00
parent a4177fb238
commit b92b0d4100
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/perforce/perforceplugin.cpp
View File

@@ -1220,6 +1220,9 @@ PerforceResponse PerforcePluginPrivate::synchronousProcess(const FilePath &worki
response.stdErr = process.cleanedStdErr(); response.stdErr = process.cleanedStdErr();
response.stdOut = process.cleanedStdOut(); response.stdOut = process.cleanedStdOut();
response.message = process.exitMessage(); response.message = process.exitMessage();
if (response.error && (flags & ErrorToWindow))
VcsOutputWindow::appendError(process.exitMessage());
return response; return response;
} }
@@ -1261,9 +1264,6 @@ PerforceResponse PerforcePluginPrivate::runP4Cmd(const FilePath &workingDir,
if (flags & ShowBusyCursor) if (flags & ShowBusyCursor)
QGuiApplication::restoreOverrideCursor(); QGuiApplication::restoreOverrideCursor();
if (response.error && (flags & ErrorToWindow))
VcsOutputWindow::appendError(response.message);
return response; return response;
} }