From b93fe5a49e2025d637462decac22027a8f5ce8f7 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Thu, 3 Nov 2016 11:32:12 +0100 Subject: [PATCH] EditorManager: Fix timing of aboutToSave signal "Save as" sent it before even the new name was asked. Change-Id: I8f791689267e57e63d51990af96373f653e54943 Reviewed-by: David Schulz --- src/plugins/coreplugin/editormanager/editormanager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/coreplugin/editormanager/editormanager.cpp b/src/plugins/coreplugin/editormanager/editormanager.cpp index 5db180a4473..cd381ad4a25 100644 --- a/src/plugins/coreplugin/editormanager/editormanager.cpp +++ b/src/plugins/coreplugin/editormanager/editormanager.cpp @@ -2100,7 +2100,6 @@ bool EditorManagerPrivate::saveDocumentAs(IDocument *document) if (!document) return false; - emit m_instance->aboutToSave(document); Utils::MimeDatabase mdb; const QString filter = Utils::MimeDatabase::allFiltersString(); QString selectedFilter; @@ -2130,6 +2129,7 @@ bool EditorManagerPrivate::saveDocumentAs(IDocument *document) EditorManager::closeDocuments(QList() << otherDocument, false); } + emit m_instance->aboutToSave(document); const bool success = DocumentManager::saveDocument(document, absoluteFilePath); document->checkPermissions();