PluginView: Functional style dependency list creation

Change-Id: I08c6aeb8be55e73a9d8e55e264046afc19c9e4b9
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

src/libs/extensionsystem/plugindetailsview.cpp

@@ -29,6 +29,8 @@
 #include "pluginmanager.h"
 #include "pluginspec.h"
 
+#include <utils/algorithm.h>
+
 #include <QDir>
 #include <QRegExp>
 
@@ -88,23 +90,6 @@ void PluginDetailsView::update(PluginSpec *spec)
     const QString platformString = tr("%1 (current: \"%2\")").arg(pluginPlatformString,
                                                                   PluginManager::platformName());
     m_ui->platforms->setText(platformString);
-    QStringList depStrings;
+    const QStringList depStrings = Utils::transform<QList>(spec->dependencies(), &PluginDependency::toString);
-    foreach (const PluginDependency &dep, spec->dependencies()) {
-        QString depString = dep.name;
-        depString += QLatin1String(" (");
-        depString += dep.version;
-        switch (dep.type) {
-        case PluginDependency::Required:
-            break;
-        case PluginDependency::Optional:
-            depString += QLatin1String(", optional");
-            break;
-        case PluginDependency::Test:
-            depString += QLatin1String(", test");
-            break;
-        }
-        depString += QLatin1Char(')');
-        depStrings.append(depString);
-    }
     m_ui->dependencies->addItems(depStrings);
 }

src/libs/extensionsystem/pluginspec.cpp

@@ -146,6 +146,23 @@ bool PluginDependency::operator==(const PluginDependency &other) const
     return name == other.name && version == other.version && type == other.type;
 }
 
+static QString typeString(PluginDependency::Type type)
+{
+    switch (type) {
+    case PluginDependency::Required:
+        return QString();
+    case PluginDependency::Optional:
+        return ", optional";
+    case PluginDependency::Test:
+        return ", test";
+    }
+}
+
+QString PluginDependency::toString() const
+{
+    return name + " (" + version + typeString(type) + ")";
+}
+
 /*!
     \internal
 */

src/libs/extensionsystem/pluginspec.h

@@ -63,6 +63,7 @@ struct EXTENSIONSYSTEM_EXPORT PluginDependency
     QString version;
     Type type;
     bool operator==(const PluginDependency &other) const;
+    QString toString() const;
 };
 
 uint qHash(const ExtensionSystem::PluginDependency &value);