feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix crash

Browse Source 
We have to check if the view is actually detached.

Change-Id: I160c1a15f921092ef66999ed6a27ffcdbbe205d9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Thomas Hartmann
2020-10-05 19:26:13 +02:00
parent b2b35eeddc
commit b9cc9c9bfa
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/components/connectioneditor/bindingmodel.cpp
View File

@@ -56,8 +56,10 @@ void BindingModel::resetModel()
setHorizontalHeaderLabels( setHorizontalHeaderLabels(
QStringList({tr("Item"), tr("Property"), tr("Source Item"), tr("Source Property")})); QStringList({tr("Item"), tr("Property"), tr("Source Item"), tr("Source Property")}));
if (connectionView()->isAttached()) {
for (const ModelNode modelNode : connectionView()->selectedModelNodes()) for (const ModelNode modelNode : connectionView()->selectedModelNodes())
addModelNode(modelNode); addModelNode(modelNode);
}
endResetModel(); endResetModel();
} }

2
src/plugins/qmldesigner/components/connectioneditor/dynamicpropertiesmodel.cpp
View File

@@ -131,8 +131,10 @@ void DynamicPropertiesModel::resetModel()
setHorizontalHeaderLabels( setHorizontalHeaderLabels(
QStringList({tr("Item"), tr("Property"), tr("Property Type"), tr("Property Value")})); QStringList({tr("Item"), tr("Property"), tr("Property Type"), tr("Property Value")}));
if (connectionView()->isAttached()) {
for (const ModelNode modelNode : connectionView()->selectedModelNodes()) for (const ModelNode modelNode : connectionView()->selectedModelNodes())
addModelNode(modelNode); addModelNode(modelNode);
}
endResetModel(); endResetModel();
} }