feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Axivion: Use more const references

Browse Source 
Instead of copying potentially big vectors / maps.

Change-Id: Ib367d18b7afb8f00551f54e8f2b2dd5c18a018c3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Jarek Kobus
2024-01-30 15:52:33 +01:00
parent 32890c59af
commit ba4df4555b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/axivion/axivionoutputpane.cpp
View File

@@ -456,12 +456,12 @@ void IssuesWidget::addIssues(const Dto::IssueTableDto &dto)
if (dto.totalRemovedCount.has_value()) if (dto.totalRemovedCount.has_value())
m_removedFilter->setText(QString::number(dto.totalRemovedCount.value())); m_removedFilter->setText(QString::number(dto.totalRemovedCount.value()));
const std::vector<Dto::ColumnInfoDto> tableColumns = m_currentTableInfo->columns; const std::vector<Dto::ColumnInfoDto> &tableColumns = m_currentTableInfo->columns;
const std::vector<std::map<QString, Dto::Any>> rows = dto.rows; const std::vector<std::map<QString, Dto::Any>> &rows = dto.rows;
for (auto row : rows) { for (const auto &row : rows) {
QStringList data; QStringList data;
for (auto column : tableColumns) { for (const auto &column : tableColumns) {
auto it = row.find(column.key); const auto it = row.find(column.key);
if (it != row.end()) { if (it != row.end()) {
QString value = anyToSimpleString(it->second); QString value = anyToSimpleString(it->second);
if (column.key == "id") if (column.key == "id")