feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Prevent calling the node instance view directly

Browse Source 
Views should not write to the node instance view directly. Instead they
should use the model for manipulation.

Change-Id: I3941cc691addab939b8032952230cbe03951730b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Marco Bubke
2022-10-10 17:41:03 +02:00
parent 21b0a69331
commit ba891e7f34
24 changed files with 95 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/qmldesigner/components/edit3d/edit3dview.cpp
View File

@@ -840,8 +840,7 @@ void Edit3DView::dropMaterial(const ModelNode &matNode, const QPointF &pos)
void Edit3DView::dropBundleMaterial(const QPointF &pos)
{
m_nodeAtPosReqType = NodeAtPosReqType::BundleMaterialDrop;
QmlDesignerPlugin::instance()->viewManager().nodeInstanceView()->view3DAction(
View3DActionType::GetNodeAtPos, pos);
emitView3DAction(View3DActionType::GetNodeAtPos, pos);
}
} // namespace QmlDesigner