feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Clean up RefactorOverlay::paintMarker

Browse Source 
* Rename variables for readability
* Use const

Change-Id: I74d44a5075738b1aef28a97f647431848564544a
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This commit is contained in:
Nikolai Kosjar
2016-02-08 11:11:32 +01:00
parent b34b019c10
commit bab230313d
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/texteditor/refactoroverlay.cpp
View File

@@ -64,27 +64,28 @@ RefactorMarker RefactorOverlay::markerAt(const QPoint &pos) const
void RefactorOverlay::paintMarker(const RefactorMarker& marker, QPainter *painter, const QRect &clip)
{
QPointF offset = m_editor->contentOffset();
QRectF geometry = m_editor->blockBoundingGeometry(marker.cursor.block()).translated(offset);
const QPointF offset = m_editor->contentOffset();
const QRectF geometry = m_editor->blockBoundingGeometry(marker.cursor.block()).translated(offset);
if (geometry.top() > clip.bottom() + 10 || geometry.bottom() < clip.top() - 10)
return; // marker not visible
QTextCursor cursor = marker.cursor;
QRect r = m_editor->cursorRect(cursor);
const QTextCursor cursor = marker.cursor;
const QRect cursorRect = m_editor->cursorRect(cursor);
QIcon icon = marker.icon;
if (icon.isNull())
icon = m_icon;
QSize sz = icon.actualSize(QSize(m_editor->fontMetrics().width(QLatin1Char(' '))+2, r.height()));
const QSize proposedIconSize = QSize(m_editor->fontMetrics().width(QLatin1Char(' ')) + 2,
cursorRect.height());
const QSize actualIconSize = icon.actualSize(proposedIconSize);
int x = r.right();
marker.rect = QRect(x, r.top(), sz.width(), sz.height());
const int x = cursorRect.right();
marker.rect = QRect(x, cursorRect.top(), actualIconSize.width(), actualIconSize.height());
icon.paint(painter, marker.rect);
m_maxWidth = qMax((qreal)m_maxWidth, x + sz.width() - offset.x());
m_maxWidth = qMax(m_maxWidth, x + actualIconSize.width() - int(offset.x()));
}
} // namespace TextEditor