From bb0030e907433a305a10ebfd538b6bb757b4c06f Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Wed, 20 Jul 2022 16:28:40 +0200
Subject: [PATCH] CustomToolChainConfigWidget: Avoid using sender()

Change-Id: Ic678d0f1edee7e5a36c9d3a1c467830a5325bd07
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
---
 src/plugins/projectexplorer/customtoolchain.cpp | 11 ++++-------
 src/plugins/projectexplorer/customtoolchain.h   |  2 +-
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/plugins/projectexplorer/customtoolchain.cpp b/src/plugins/projectexplorer/customtoolchain.cpp
index 92de0ae165a..1eff9a45e0f 100644
--- a/src/plugins/projectexplorer/customtoolchain.cpp
+++ b/src/plugins/projectexplorer/customtoolchain.cpp
@@ -427,9 +427,9 @@ CustomToolChainConfigWidget::CustomToolChainConfigWidget(CustomToolChain *tc) :
     connect(m_makeCommand, &PathChooser::rawPathChanged, this, &ToolChainConfigWidget::dirty);
     connect(m_abiWidget, &AbiWidget::abiChanged, this, &ToolChainConfigWidget::dirty);
     connect(m_predefinedMacros, &QPlainTextEdit::textChanged,
-            this, &CustomToolChainConfigWidget::updateSummaries);
+            this, [this] { updateSummaries(m_predefinedDetails); });
     connect(m_headerPaths, &QPlainTextEdit::textChanged,
-            this, &CustomToolChainConfigWidget::updateSummaries);
+            this, [this] { updateSummaries(m_headerDetails); });
     connect(m_cxx11Flags, &QLineEdit::textChanged, this, &ToolChainConfigWidget::dirty);
     connect(m_mkspecs, &QLineEdit::textChanged, this, &ToolChainConfigWidget::dirty);
     connect(m_errorParserComboBox, &QComboBox::currentIndexChanged,
@@ -437,12 +437,9 @@ CustomToolChainConfigWidget::CustomToolChainConfigWidget(CustomToolChain *tc) :
     errorParserChanged();
 }
 
-void CustomToolChainConfigWidget::updateSummaries()
+void CustomToolChainConfigWidget::updateSummaries(TextEditDetailsWidget *detailsWidget)
 {
-    if (sender() == m_predefinedMacros)
-        m_predefinedDetails->updateSummaryText();
-    else
-        m_headerDetails->updateSummaryText();
+    detailsWidget->updateSummaryText();
     emit dirty();
 }
 
diff --git a/src/plugins/projectexplorer/customtoolchain.h b/src/plugins/projectexplorer/customtoolchain.h
index dbd00d7a112..7c04f13e50d 100644
--- a/src/plugins/projectexplorer/customtoolchain.h
+++ b/src/plugins/projectexplorer/customtoolchain.h
@@ -141,7 +141,7 @@ public:
     CustomToolChainConfigWidget(CustomToolChain *);
 
 private:
-    void updateSummaries();
+    void updateSummaries(TextEditDetailsWidget *detailsWidget);
     void errorParserChanged(int index = -1);
 
 protected: