feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs: Introduce IVersionControl::unmanagedFiles()

Browse Source 
... and use it in VcsManager::promptToAdd().
This is purely a refactoring. The different IVersionControl subclasses
can (and should) override the naive base class implementation in the
future.

Change-Id: Ifdf49852a98f53a95dad1a89131243b21052bc66
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Christian Kandeler
2019-11-14 11:14:11 +01:00
parent 18ecbb9b14
commit bb5727de17
3 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/coreplugin/vcsmanager.cpp
View File

@@ -400,12 +400,7 @@ void VcsManager::promptToAdd(const QString &directory, const QStringList &fileNa
if (!vc || !vc->supportsOperation(IVersionControl::AddOperation))
return;
QStringList unmanagedFiles;
QDir dir(directory);
foreach (const QString &fileName, fileNames) {
if (!vc->managesFile(directory, dir.relativeFilePath(fileName)))
unmanagedFiles << fileName;
}
const QStringList unmanagedFiles = vc->unmanagedFiles(directory, fileNames);
if (unmanagedFiles.isEmpty())
return;