CppIncludeHierarchy: Replace foreach with range-for

Change-Id: I501a0a504175307ccce3cc4781645de9ae1679a8
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Andre Hartmann
2019-01-21 20:47:50 +01:00
committed by André Hartmann
parent d7058e1afe
commit bb72406dad

View File

@@ -278,7 +278,7 @@ QStringList CppIncludeHierarchyModel::mimeTypes() const
QMimeData *CppIncludeHierarchyModel::mimeData(const QModelIndexList &indexes) const QMimeData *CppIncludeHierarchyModel::mimeData(const QModelIndexList &indexes) const
{ {
auto data = new DropMimeData; auto data = new DropMimeData;
foreach (const QModelIndex &index, indexes) { for (const QModelIndex &index : indexes) {
auto link = index.data(LinkRole).value<Utils::Link>(); auto link = index.data(LinkRole).value<Utils::Link>();
if (link.hasValidTarget()) if (link.hasValidTarget())
data->addFile(link.targetFileName, link.targetLine, link.targetColumn); data->addFile(link.targetFileName, link.targetLine, link.targetColumn);
@@ -357,7 +357,7 @@ public:
private: private:
void onItemActivated(const QModelIndex &index); void onItemActivated(const QModelIndex &index);
void editorsClosed(QList<IEditor *> editors); void editorsClosed(const QList<IEditor *> &editors);
void showNoIncludeHierarchyLabel(); void showNoIncludeHierarchyLabel();
void showIncludeHierarchy(); void showIncludeHierarchy();
void syncFromEditorManager(); void syncFromEditorManager();
@@ -468,9 +468,9 @@ void CppIncludeHierarchyWidget::onItemActivated(const QModelIndex &index)
Constants::CPPEDITOR_ID); Constants::CPPEDITOR_ID);
} }
void CppIncludeHierarchyWidget::editorsClosed(QList<IEditor *> editors) void CppIncludeHierarchyWidget::editorsClosed(const QList<IEditor *> &editors)
{ {
foreach (IEditor *editor, editors) { for (const IEditor *editor : editors) {
if (m_editor == editor) if (m_editor == editor)
perform(); perform();
} }