From bbb4966cd734ea6c34455e091af0d110ea86b6e9 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Thu, 21 Jul 2022 11:30:02 +0200 Subject: [PATCH] DockFocusController: Avoid using sender() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It looks like we can be connected to only one DockAreaWidget, and it's always m_focusArea, so use m_focusArea instead of sender(). Change-Id: I3b226d98b05c857a20c126f76db195d4b79fc5c1 Reviewed-by: Henning Gründl --- src/libs/advanceddockingsystem/dockfocuscontroller.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/libs/advanceddockingsystem/dockfocuscontroller.cpp b/src/libs/advanceddockingsystem/dockfocuscontroller.cpp index 4a8038f6eb6..b96c23f7cbe 100644 --- a/src/libs/advanceddockingsystem/dockfocuscontroller.cpp +++ b/src/libs/advanceddockingsystem/dockfocuscontroller.cpp @@ -215,14 +215,10 @@ namespace ADS void DockFocusController::onFocusedDockAreaViewToggled(bool open) { - if (d->m_dockManager->isRestoringState()) + if (d->m_dockManager->isRestoringState() || !d->m_focusedArea || open) return; - DockAreaWidget* dockArea = qobject_cast(sender()); - if (!dockArea || open) - return; - - auto container = dockArea->dockContainer(); + auto container = d->m_focusedArea->dockContainer(); auto openedDockAreas = container->openedDockAreas(); if (openedDockAreas.isEmpty()) return;