feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Designer: Remove further dead code from newclasswidget.*

Browse Source 
The feature with base classes and class types was disabled by hiding the
respective ui fields. Also, the code to handle these features is very
incomplete.
This change removes these ui fileds and unused code remnands.

Change-Id: I27c3288e4937f0d605da85b2f33aba640dcf7371
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Alessandro Portale
2022-08-19 19:52:59 +02:00
parent 912b016ab0
commit bbbc90ee1d
3 changed files with 7 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/plugins/designer/cpp/newclasswidget.cpp
View File

@@ -48,11 +48,6 @@ NewClassWidget::NewClassWidget(QWidget *parent) :
{
d->m_ui.setupUi(this);
d->m_ui.baseClassLabel->setVisible(false);
d->m_ui.baseClassComboBox->setVisible(false);
d->m_ui.classTypeLabel->setVisible(false);
d->m_ui.classTypeComboBox->setVisible(false);
d->m_ui.classLineEdit->setNamespacesEnabled(true);
setNamesDelimiter(QLatin1String("::"));
@@ -60,10 +55,6 @@ NewClassWidget::NewClassWidget(QWidget *parent) :
this, &NewClassWidget::slotUpdateFileNames);
connect(d->m_ui.classLineEdit, &QLineEdit::textEdited,
this, &NewClassWidget::classNameEdited);
connect(d->m_ui.baseClassComboBox, &QComboBox::currentIndexChanged,
this, &NewClassWidget::suggestClassNameFromBase);
connect(d->m_ui.baseClassComboBox, &QComboBox::editTextChanged,
this, &NewClassWidget::slotValidChanged);
connect(d->m_ui.classLineEdit, &Utils::FancyLineEdit::validChanged,
this, &NewClassWidget::slotValidChanged);
connect(d->m_ui.headerFileLineEdit, &Utils::FancyLineEdit::validChanged,
@@ -87,8 +78,6 @@ NewClassWidget::NewClassWidget(QWidget *parent) :
this, &NewClassWidget::slotActivated);
connect(d->m_ui.pathChooser, &Utils::PathChooser::returnPressed,
this, &NewClassWidget::slotActivated);
setClassType(NoClassType);
}
NewClassWidget::~NewClassWidget()
@@ -103,20 +92,6 @@ void NewClassWidget::classNameEdited()
d->m_classEdited = true;
}
void NewClassWidget::suggestClassNameFromBase()
{
if (debugNewClassWidget)
qDebug() << Q_FUNC_INFO << d->m_headerExtension << d->m_sourceExtension;
if (d->m_classEdited)
return;
// Suggest a class unless edited ("QMainWindow"->"MainWindow")
QString base = baseClassName();
if (base.startsWith(QLatin1Char('Q'))) {
base.remove(0, 1);
setClassName(base);
}
}
void NewClassWidget::setClassName(const QString &suggestedName)
{
if (debugNewClassWidget)
@@ -130,11 +105,6 @@ QString NewClassWidget::className() const
return d->m_ui.classLineEdit->text();
}
QString NewClassWidget::baseClassName() const
{
return d->m_ui.baseClassComboBox->currentText();
}
QString NewClassWidget::sourceFileName() const
{
return d->m_ui.sourceFileLineEdit->text();
@@ -195,11 +165,6 @@ void NewClassWidget::setLowerCaseFiles(bool v)
d->m_ui.classLineEdit->setLowerCaseFileName(v);
}
void NewClassWidget::setClassType(ClassType ct)
{
d->m_ui.classTypeComboBox->setCurrentIndex(ct);
}
void NewClassWidget::setNamesDelimiter(const QString &delimiter)
{
d->m_ui.classLineEdit->setNamespaceDelimiter(delimiter);