feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Simplify CMakeProcess::finished signature

Browse Source 
The parameters were never used, and start to look alien in the
presence of QtcProcess::result().

Change-Id: Ie2d6a051b439b5e9161d565b84efb78dbe17487f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
hjk
2021-06-08 13:40:45 +02:00
parent 904b236e58
commit bc2af18a41
4 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/cmakeprojectmanager/cmakeprocess.h
View File

@@ -41,7 +41,8 @@
namespace CMakeProjectManager {
namespace Internal {
class CMakeProcess : public QObject {
class CMakeProcess : public QObject
{
Q_OBJECT
public:
@@ -65,7 +66,7 @@ public:
int lastExitCode() const { return m_lastExitCode; }
signals:
void started();
void finished(int exitCode, QProcess::ExitStatus exitStatus);
void finished();
private:
void handleProcessFinished(int code, QProcess::ExitStatus status);