forked from qt-creator/qt-creator
CMake: Simplify CMakeProcess::finished signature
The parameters were never used, and start to look alien in the presence of QtcProcess::result(). Change-Id: Ie2d6a051b439b5e9161d565b84efb78dbe17487f Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
@@ -214,7 +214,7 @@ void CMakeProcess::handleProcessFinished(int code, QProcess::ExitStatus status)
|
||||
|
||||
m_future->reportFinished();
|
||||
|
||||
emit finished(code, status);
|
||||
emit finished();
|
||||
|
||||
const QString elapsedTime = Utils::formatElapsedTime(m_elapsed.elapsed());
|
||||
BuildSystem::appendBuildSystemOutput(elapsedTime);
|
||||
|
@@ -41,7 +41,8 @@
|
||||
namespace CMakeProjectManager {
|
||||
namespace Internal {
|
||||
|
||||
class CMakeProcess : public QObject {
|
||||
class CMakeProcess : public QObject
|
||||
{
|
||||
Q_OBJECT
|
||||
|
||||
public:
|
||||
@@ -65,7 +66,7 @@ public:
|
||||
int lastExitCode() const { return m_lastExitCode; }
|
||||
signals:
|
||||
void started();
|
||||
void finished(int exitCode, QProcess::ExitStatus exitStatus);
|
||||
void finished();
|
||||
|
||||
private:
|
||||
void handleProcessFinished(int code, QProcess::ExitStatus status);
|
||||
|
@@ -376,13 +376,10 @@ void FileApiReader::startCMakeState(const QStringList &configurationArguments)
|
||||
m_cmakeProcess->run(m_parameters, configurationArguments);
|
||||
}
|
||||
|
||||
void FileApiReader::cmakeFinishedState(int code, QProcess::ExitStatus status)
|
||||
void FileApiReader::cmakeFinishedState()
|
||||
{
|
||||
qCDebug(cmakeFileApiMode) << "FileApiReader: CMAKE FINISHED STATE.";
|
||||
|
||||
Q_UNUSED(code)
|
||||
Q_UNUSED(status)
|
||||
|
||||
m_lastCMakeExitCode = m_cmakeProcess->lastExitCode();
|
||||
m_cmakeProcess.release()->deleteLater();
|
||||
|
||||
|
@@ -88,7 +88,7 @@ private:
|
||||
void startState();
|
||||
void endState(const QFileInfo &replyFi);
|
||||
void startCMakeState(const QStringList &configurationArguments);
|
||||
void cmakeFinishedState(int code, QProcess::ExitStatus status);
|
||||
void cmakeFinishedState();
|
||||
|
||||
void replyDirectoryHasChanged(const QString &directory) const;
|
||||
void makeBackupConfiguration(bool store);
|
||||
|
Reference in New Issue
Block a user