feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix logical XOR

Browse Source 
The '^' is the bitwise XOR, we should use logical XOR in
these contexts. The operator!=() should serve for it.

More info and reasoning:
https://stackoverflow.com/questions/24542

Change-Id: I1bd70bdcab25455f409594f0f14c209d1de11d18
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-09-30 18:45:35 +02:00
parent 0c39484b60
commit bc4c1faf73
6 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/debugger/threadshandler.cpp
View File

@@ -244,9 +244,9 @@ void ThreadsHandler::sort(int column, Qt::SortOrder order)
if (v1 == v2)
return false;
if (column == 0)
return (v1.toInt() < v2.toInt()) ^ (order == Qt::DescendingOrder);
return (v1.toInt() < v2.toInt()) != (order == Qt::DescendingOrder);
// FIXME: Use correct toXXX();
return (v1.toString() < v2.toString()) ^ (order == Qt::DescendingOrder);
return (v1.toString() < v2.toString()) != (order == Qt::DescendingOrder);
});
}